Re: [PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory

2022-07-04 Thread Fidaullah Noonari
Hi Dmitry, > alloc_sz = RTE_ALIGN_CEIL(RTE_ALIGN_CEIL(elt_size, align) + > MALLOC_ELEM_OVERHEAD, pg_sz); > I am submitting a patch regarding this > 2. Alignment calculation depends on whether we allocated new pages or not: > > malloc_heap_alloc_on_heap_id(align = 0) -> > heap_allo

Re: [PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory

2022-06-23 Thread David Marchand
On Wed, May 25, 2022 at 7:18 AM Fidaullah Noonari wrote: > > if rte malloc is called to allocate memory of size > is between multiple of hugepage size minus malloc_header_len > and hugepage size rte_malloc fails to allocate memory. > this fix replaces malloc_elem_trailer_len with > malloc_elem_ove

Re: [PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory

2022-06-22 Thread Dmitry Kozlyuk
2022-06-22 19:03 (UTC+0200), David Marchand: > On Sat, Jun 18, 2022 at 1:29 PM Dmitry Kozlyuk > wrote: > > > > Hi Fidaullah, > > > > Thanks for the fix, > > Acked-by: Dmitry Kozlyuk > > This seems backport material. > Dmitry, Anatoly, do you agree? If so I'll mark it when applying. > > As fo

Re: [PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory

2022-06-22 Thread David Marchand
On Sat, Jun 18, 2022 at 1:29 PM Dmitry Kozlyuk wrote: > > Hi Fidaullah, > > Thanks for the fix, > Acked-by: Dmitry Kozlyuk This seems backport material. Dmitry, Anatoly, do you agree? If so I'll mark it when applying. As for a Fixes: line, the closer commit touching this part is 07dcbfe0101f ("

Re: [PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory

2022-06-18 Thread Dmitry Kozlyuk
Hi Fidaullah, Thanks for the fix, Acked-by: Dmitry Kozlyuk Anatoly, I noticed a couple of other things while testing this. 1. Consider: elt_size = pg_sz - MALLOC_ELEM_OVERHEAD rte_malloc(align=0) which is converted to align = 1. Obviously, such an element fits into one page, however: alloc_

Re: [PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory

2022-06-16 Thread David Marchand
On Wed, May 25, 2022 at 7:18 AM Fidaullah Noonari wrote: > > if rte malloc is called to allocate memory of size > is between multiple of hugepage size minus malloc_header_len > and hugepage size rte_malloc fails to allocate memory. > this fix replaces malloc_elem_trailer_len with > malloc_elem_ove