Re: [PATCH] eal: factorize lcore main loop

2022-03-25 Thread Tyler Retzlaff
On Fri, Mar 25, 2022 at 04:09:50PM +0100, David Marchand wrote: > On Fri, Mar 25, 2022 at 3:58 PM Thomas Monjalon wrote: > > > > But seeing how this code has been there from day 1, I would not > > > > request a backport. > > > > > > this looks better to me it ends up being a bit less code and it s

Re: [PATCH] eal: factorize lcore main loop

2022-03-25 Thread David Marchand
On Fri, Mar 25, 2022 at 3:58 PM Thomas Monjalon wrote: > > > But seeing how this code has been there from day 1, I would not > > > request a backport. > > > > this looks better to me it ends up being a bit less code and it solves > > the problem in a general fashion for platforms including windows

Re: [PATCH] eal: factorize lcore main loop

2022-03-25 Thread Thomas Monjalon
25/03/2022 13:11, Tyler Retzlaff: > On Thu, Mar 24, 2022 at 03:44:23PM +0100, David Marchand wrote: > > On Thu, Mar 24, 2022 at 9:31 AM Tyler Retzlaff > > wrote: > > > > diff --git a/lib/eal/common/eal_common_thread.c > > > > b/lib/eal/common/eal_common_thread.c > > > > index 684bea166c..256de91a

Re: [PATCH] eal: factorize lcore main loop

2022-03-25 Thread Tyler Retzlaff
On Wed, Mar 23, 2022 at 10:30:01AM +0100, David Marchand wrote: > All OS implementations provide the same main loop. > Introduce helpers (shared for Linux and FreeBSD) to handle synchronisation > between main and threads and factorize the rest as common code. > Thread id are now logged as string in

Re: [PATCH] eal: factorize lcore main loop

2022-03-25 Thread Tyler Retzlaff
On Thu, Mar 24, 2022 at 03:44:23PM +0100, David Marchand wrote: > On Thu, Mar 24, 2022 at 9:31 AM Tyler Retzlaff > wrote: > > > diff --git a/lib/eal/common/eal_common_thread.c > > > b/lib/eal/common/eal_common_thread.c > > > index 684bea166c..256de91abc 100644 > > > --- a/lib/eal/common/eal_commo

Re: [PATCH] eal: factorize lcore main loop

2022-03-24 Thread David Marchand
On Thu, Mar 24, 2022 at 9:31 AM Tyler Retzlaff wrote: > > diff --git a/lib/eal/common/eal_common_thread.c > > b/lib/eal/common/eal_common_thread.c > > index 684bea166c..256de91abc 100644 > > --- a/lib/eal/common/eal_common_thread.c > > +++ b/lib/eal/common/eal_common_thread.c > > @@ -9,6 +9,7 @@

Re: [PATCH] eal: factorize lcore main loop

2022-03-24 Thread Tyler Retzlaff
On Wed, Mar 23, 2022 at 10:30:01AM +0100, David Marchand wrote: > All OS implementations provide the same main loop. > Introduce helpers (shared for Linux and FreeBSD) to handle synchronisation > between main and threads and factorize the rest as common code. > Thread id are now logged as string in

RE: [PATCH] eal: factorize lcore main loop

2022-03-23 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 23 March 2022 10.30 > > All OS implementations provide the same main loop. > Introduce helpers (shared for Linux and FreeBSD) to handle > synchronisation > between main and threads and factorize the rest as common code. >