RE: [PATCH] eal: add notes to SMP memory barrier APIs

2023-07-02 Thread Ruifeng Wang
@redhat.com > >> Cc: dev@dpdk.org; konstantin.v.anan...@yandex.ru; Honnappa > >> Nagarahalli ; nd > >> Subject: Re: [PATCH] eal: add notes to SMP memory barrier APIs > >> > >> On 2023-06-21 08:44, Ruifeng Wang wrote: > >>> The rte_smp_xx

Re: [PATCH] eal: add notes to SMP memory barrier APIs

2023-06-29 Thread Mattias Rönnblom
: add notes to SMP memory barrier APIs On 2023-06-21 08:44, Ruifeng Wang wrote: The rte_smp_xx() APIs are deprecated. But it is not mentioned in the function header. Added notes in function header for clarification. Signed-off-by: Ruifeng Wang --- lib/eal/include/generic/rte_atomic.h | 15

Re: [PATCH] eal: add notes to SMP memory barrier APIs

2023-06-25 Thread Thomas Monjalon
25/06/2023 10:45, Ruifeng Wang: > From: Tyler Retzlaff > > On Thu, Jun 22, 2023 at 08:19:30PM +0200, Mattias R�nnblom wrote: > > > On 2023-06-21 08:44, Ruifeng Wang wrote: > > > >+ * This function is deprecated. It adds complexity to the memory > > > >+ model > > > >+ * used by this project. C

RE: [PATCH] eal: add notes to SMP memory barrier APIs

2023-06-25 Thread Ruifeng Wang
bject: Re: [PATCH] eal: add notes to SMP memory barrier APIs > > On Thu, Jun 22, 2023 at 08:19:30PM +0200, Mattias R�nnblom wrote: > > On 2023-06-21 08:44, Ruifeng Wang wrote: > > >The rte_smp_xx() APIs are deprecated. But it is not mentioned in the > > >function head

RE: [PATCH] eal: add notes to SMP memory barrier APIs

2023-06-25 Thread Ruifeng Wang
> -Original Message- > From: Mattias Rönnblom > Sent: Friday, June 23, 2023 2:20 AM > To: Ruifeng Wang ; tho...@monjalon.net; > david.march...@redhat.com > Cc: dev@dpdk.org; konstantin.v.anan...@yandex.ru; Honnappa Nagarahalli > ; nd > Subject: Re: [PATCH] eal:

RE: [PATCH] eal: add notes to SMP memory barrier APIs

2023-06-25 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 21, 2023 3:30 PM > To: Ruifeng Wang > Cc: david.march...@redhat.com; dev@dpdk.org; konstantin.v.anan...@yandex.ru; > Honnappa > Nagarahalli ; nd > Subject: Re: [PATCH] eal: add notes to SMP mem

Re: [PATCH] eal: add notes to SMP memory barrier APIs

2023-06-23 Thread Tyler Retzlaff
On Thu, Jun 22, 2023 at 08:19:30PM +0200, Mattias Rönnblom wrote: > On 2023-06-21 08:44, Ruifeng Wang wrote: > >The rte_smp_xx() APIs are deprecated. But it is not mentioned > >in the function header. > >Added notes in function header for clarification. > > > >Signed-off-by: Ruifeng Wang > >--- >

Re: [PATCH] eal: add notes to SMP memory barrier APIs

2023-06-22 Thread Mattias Rönnblom
On 2023-06-21 08:44, Ruifeng Wang wrote: The rte_smp_xx() APIs are deprecated. But it is not mentioned in the function header. Added notes in function header for clarification. Signed-off-by: Ruifeng Wang --- lib/eal/include/generic/rte_atomic.h | 15 +++ 1 file changed, 15 inser

Re: [PATCH] eal: add notes to SMP memory barrier APIs

2023-06-21 Thread Thomas Monjalon
21/06/2023 08:44, Ruifeng Wang: > + * @note > + * This function is deprecated. It adds complexity to the memory model > + * used by this project. C11 memory model should always be used. > + * rte_atomic_thread_fence() should be used instead. > */ > static inline void rte_smp_mb(void); I thin