Re: [PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-28 Thread Tyler Retzlaff
On Mon, Aug 28, 2023 at 12:03:40PM +0100, Bruce Richardson wrote: > On Mon, Aug 28, 2023 at 12:42:38PM +0200, Stephen Hemminger wrote: > >For humor > >#define RTE_CASTAWAY(x) ((void *)(uinptr_t)(x)) > > Yes, actually thought about that. Was also wondering about making it an > inline functi

Re: [PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-28 Thread Ferruh Yigit
On 8/28/2023 12:03 PM, Bruce Richardson wrote: > On Mon, Aug 28, 2023 at 12:42:38PM +0200, Stephen Hemminger wrote: >>For humor >>#define RTE_CASTAWAY(x) ((void *)(uinptr_t)(x)) > > Yes, actually thought about that. Was also wondering about making it an > inline function rather than macro,

Re: [PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-28 Thread Bruce Richardson
On Mon, Aug 28, 2023 at 12:42:38PM +0200, Stephen Hemminger wrote: >For humor >#define RTE_CASTAWAY(x) ((void *)(uinptr_t)(x)) Yes, actually thought about that. Was also wondering about making it an inline function rather than macro, to ensure its only used on pointers, and to make clear w

Re: [PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-28 Thread Stephen Hemminger
For humor #define RTE_CASTAWAY(x) ((void *)(uinptr_t)(x)) On Mon, Aug 28, 2023, 12:29 PM Bruce Richardson wrote: > On Mon, Aug 28, 2023 at 11:29:05AM +0200, David Marchand wrote: > > On Fri, Aug 25, 2023 at 5:29 PM Bruce Richardson > > wrote: > > > > > > When doing a build for a system with WAI

Re: [PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-28 Thread Bruce Richardson
On Mon, Aug 28, 2023 at 11:29:05AM +0200, David Marchand wrote: > On Fri, Aug 25, 2023 at 5:29 PM Bruce Richardson > wrote: > > > > When doing a build for a system with WAITPKG support and a modern > > compiler, we get build errors for the "_umonitor" intrinsic, due to the > > casting away of the

Re: [PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-28 Thread David Marchand
On Fri, Aug 25, 2023 at 5:29 PM Bruce Richardson wrote: > > When doing a build for a system with WAITPKG support and a modern > compiler, we get build errors for the "_umonitor" intrinsic, due to the > casting away of the "volatile" on the parameter. > > ../lib/eal/x86/rte_power_intrinsics.c: In f

Re: [PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-28 Thread David Marchand
On Mon, Aug 28, 2023 at 9:08 AM David Marchand wrote: > > Hello Bruce, > > On Fri, Aug 25, 2023 at 5:29 PM Bruce Richardson > wrote: > > > > When doing a build for a system with WAITPKG support and a modern > > compiler, we get build errors for the "_umonitor" intrinsic, due to the > > casting aw

Re: [PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-28 Thread David Marchand
Hello Bruce, On Fri, Aug 25, 2023 at 5:29 PM Bruce Richardson wrote: > > When doing a build for a system with WAITPKG support and a modern > compiler, we get build errors for the "_umonitor" intrinsic, due to the > casting away of the "volatile" on the parameter. > > ../lib/eal/x86/rte_power_intr

RE: [PATCH] eal/x86: fix build on systems with WAITPKG support

2023-08-25 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 25 August 2023 17.29 > > When doing a build for a system with WAITPKG support and a modern > compiler, we get build errors for the "_umonitor" intrinsic, due to the > casting away of the "volatile" on the parameter. > >