Re: [PATCH] dts: improve documentation

2024-01-15 Thread Luca Vizzarro
On 15/01/2024 09:36, Juraj Linkeš wrote: This wouldn't need to be a hard requirement. It could just be a tool that submitters could use as a starting point (which they would optionally install and use). Sorry, forgot to mention that the tool is actually a sphinx plugin, which is used through d

Re: [PATCH] dts: improve documentation

2024-01-15 Thread Juraj Linkeš
On Fri, Jan 12, 2024 at 6:16 PM Luca Vizzarro wrote: > > Hi Juraj, > > Thank you for your review! > > On 12/01/2024 13:24, Juraj Linkeš wrote: > > I have two extra suggestions apart from the comments below: > > There's a typo inside the "How To Write a Test Suite" section: > > In that case, nothin

Re: [PATCH] dts: improve documentation

2024-01-12 Thread Luca Vizzarro
Hi Juraj, Thank you for your review! On 12/01/2024 13:24, Juraj Linkeš wrote: I have two extra suggestions apart from the comments below: There's a typo inside the "How To Write a Test Suite" section: In that case, nothing will happen when they're is executed. And Mypy is missing from the list

Re: [PATCH] dts: improve documentation

2024-01-12 Thread Juraj Linkeš
I have two extra suggestions apart from the comments below: There's a typo inside the "How To Write a Test Suite" section: In that case, nothing will happen when they're is executed. And Mypy is missing from the list of linters in the "DTS Developer Tools" section, could you please add it? > diff

Re: [PATCH] dts: improve documentation

2024-01-05 Thread Luca Vizzarro
On 04/01/2024 10:52, Thomas Monjalon wrote: DTS needs to know which nodes to connect to and what hardware to use on those nodes. -Once that's configured, DTS needs a DPDK tarball and it's ready to run. +Once that's configured, DTS needs a DPDK tarball or a git ref ID and it's ready to run.

Re: [PATCH] dts: improve documentation

2024-01-04 Thread Thomas Monjalon
04/01/2024 13:34, Luca Vizzarro: > On 04/01/2024 10:52, Thomas Monjalon wrote: > >> DTS needs to know which nodes to connect to and what hardware to use on > >> those nodes. > >> -Once that's configured, DTS needs a DPDK tarball and it's ready to run. > >> +Once that's configured, DTS needs a DP

Re: [PATCH] dts: improve documentation

2024-01-04 Thread Thomas Monjalon
03/01/2024 13:54, Luca Vizzarro: > Improve instructions for installing dependencies, configuring and > launching the project. Finally, document the configuration schema > by adding more comments to the example and documenting every > property and definition. Thank you for taking care of the docume