RE: [PATCH] crypto/qat: fix build when no openssl exists

2023-10-31 Thread Dooley, Brian
Hi Ciara, > -Original Message- > From: Power, Ciara > Sent: Friday, October 27, 2023 3:23 PM > To: dev@dpdk.org > Cc: Power, Ciara ; Dooley, Brian > ; sta...@dpdk.org; Ji, Kai > Subject: [PATCH] crypto/qat: fix build when no openssl exists > > Previously some compilation errors existed

Re: [PATCH] crypto/qat: fix build when no openssl exists

2023-10-27 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 27 October 2023 15:23 To: dev@dpdk.org Cc: Power, Ciara ; Dooley, Brian ; sta...@dpdk.org ; Ji, Kai Subject: [PATCH] crypto/qat: fix build when no openssl exists Previously some compilation er

RE: [EXT] Re: [PATCH] crypto/qat: fix build for generic x86 with GCC 12

2023-01-19 Thread Akhil Goyal
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, January 17, 2023 2:33 PM > To: Akhil Goyal > Cc: David Marchand ; Kai Ji ; > dev@dpdk.org; sta...@dpdk.org; Ciara Power ; Fan > Zhang > Subject: Re: [EXT] Re: [PATCH] crypto/qat: fix build for ge

RE: [EXT] Re: [PATCH] crypto/qat: fix build

2023-01-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, January 17, 2023 8:23 AM > To: Thomas Monjalon ; De Lara Guarch, Pablo > > Cc: Ji, Kai ; akhil.go...@marvell.com; dev@dpdk.org; > sta...@dpdk.org > Subject: RE: [EXT] Re: [PATCH] crypto/qat: fix build

Re: [EXT] Re: [PATCH] crypto/qat: fix build for generic x86 with GCC 12

2023-01-17 Thread Bruce Richardson
On Tue, Jan 17, 2023 at 08:20:48AM +, Akhil Goyal wrote: > > On Tue, Jan 10, 2023 at 12:27 PM Bruce Richardson > > wrote: > > > > > > On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote: > > > > Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12"). > > > > The issue

RE: [EXT] Re: [PATCH] crypto/qat: fix build

2023-01-17 Thread Akhil Goyal
> 12/01/2023 20:30, Pablo de Lara: > > Instead of undefining AES_BLOCK_SIZE, define NO_COMPAT_IMB_API_053, > > which prevents legacy macros like AES_BLOCK_SIZE from being defined > > from IPSec MB library. > > Given we are discarding my first workaround, > your first sentence doesn't really make s

RE: [EXT] Re: [PATCH] crypto/qat: fix build for generic x86 with GCC 12

2023-01-17 Thread Akhil Goyal
> On Tue, Jan 10, 2023 at 12:27 PM Bruce Richardson > wrote: > > > > On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote: > > > Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12"). > > > The issue appears when building with the "generic" target we have in > > > devtools

Re: [PATCH] crypto/qat: fix build for generic x86 with GCC 12

2023-01-17 Thread David Marchand
On Tue, Jan 10, 2023 at 12:27 PM Bruce Richardson wrote: > > On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote: > > Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12"). > > The issue appears when building with the "generic" target we have in > > devtools/test-meson-bu

Re: [PATCH] crypto/qat: fix build

2023-01-12 Thread Thomas Monjalon
12/01/2023 20:30, Pablo de Lara: > Instead of undefining AES_BLOCK_SIZE, define NO_COMPAT_IMB_API_053, > which prevents legacy macros like AES_BLOCK_SIZE from being defined > from IPSec MB library. Given we are discarding my first workaround, your first sentence doesn't really make sense. Please g

RE: [EXT] Re: [PATCH] crypto/qat: fix build

2023-01-12 Thread Akhil Goyal
> 12/01/2023 17:16, De Lara Guarch, Pablo: > > From: Thomas Monjalon > > > 12/01/2023 14:22, De Lara Guarch, Pablo: > > > > Hi Thomas, > > > > > > > > From: Thomas Monjalon > > > > > 12/01/2023 11:32, Ji, Kai: > > > > > > Ok, a long story short, this issue should only occurred when > > > > > RTE_

Re: [PATCH] crypto/qat: fix build

2023-01-12 Thread Tyler Retzlaff
Cc: dev@dpdk.org; Tyler Retzlaff ; > > dev@dpdk.org; David Marchand ; Dooley, > > Brian ; Power, Ciara ; > > Mcnamara, John > > Subject: Re: [PATCH] crypto/qat: fix build > > > > 12/01/2023 11:32, Ji, Kai: > > > Ok, a long story short, this issue sho

Re: [PATCH] crypto/qat: fix build

2023-01-12 Thread Thomas Monjalon
12/01/2023 17:16, De Lara Guarch, Pablo: > From: Thomas Monjalon > > 12/01/2023 14:22, De Lara Guarch, Pablo: > > > Hi Thomas, > > > > > > From: Thomas Monjalon > > > > 12/01/2023 11:32, Ji, Kai: > > > > > Ok, a long story short, this issue should only occurred when > > > > RTE_QAT_LIBIPSECMB is

RE: [PATCH] crypto/qat: fix build

2023-01-12 Thread De Lara Guarch, Pablo
John > Subject: Re: [PATCH] crypto/qat: fix build > > 12/01/2023 14:22, De Lara Guarch, Pablo: > > Hi Thomas, > > > > From: Thomas Monjalon > > > 12/01/2023 11:32, Ji, Kai: > > > > Ok, a long story short, this issue should only occurred when >

Re: [PATCH] crypto/qat: fix build

2023-01-12 Thread Thomas Monjalon
12/01/2023 14:22, De Lara Guarch, Pablo: > Hi Thomas, > > From: Thomas Monjalon > > 12/01/2023 11:32, Ji, Kai: > > > Ok, a long story short, this issue should only occurred when > > RTE_QAT_LIBIPSECMB is enabled. > > > It was intend to remove Openssl lib dependency in QAT replaced with > > > ipse

RE: [PATCH] crypto/qat: fix build

2023-01-12 Thread De Lara Guarch, Pablo
; Mcnamara, John > Subject: Re: [PATCH] crypto/qat: fix build > > 12/01/2023 11:32, Ji, Kai: > > Ok, a long story short, this issue should only occurred when > RTE_QAT_LIBIPSECMB is enabled. > > It was intend to remove Openssl lib dependency in QAT replaced with >

Re: [PATCH] crypto/qat: fix build

2023-01-12 Thread Thomas Monjalon
a new thing in the lib ipsec_mb? Why defining AES_BLOCK_SIZE while IMB_AES_BLOCK_SIZE can be used and have a proper prefix? > The fully removal of Openssl dependency is already ongoing, I will take a > note to fix this properly > > Regards > > Kai > > > From: Thoma

RE: [PATCH] crypto/qat: fix build

2023-01-12 Thread Ji, Kai
, Pablo > ; Akhil Goyal > Cc: dev@dpdk.org; Tyler Retzlaff ; > dev@dpdk.org; David Marchand ; Dooley, Brian > ; Power, Ciara ; Mcnamara, > John > Subject: Re: [PATCH] crypto/qat: fix build > > Waiting for an answer here. > The commit log is not supposed to stay like t

Re: [PATCH] crypto/qat: fix build

2023-01-11 Thread Thomas Monjalon
Waiting for an answer here. The commit log is not supposed to stay like this with questions. 11/01/2023 10:03, Thomas Monjalon: > 04/01/2023 12:56, Akhil Goyal: > > > On Fri, Dec 30, 2022 at 10:07:28PM +0100, Thomas Monjalon wrote: > > > > When trying to compile on a fresh system, I hit this erro

Re: [EXT] Re: [PATCH] crypto/qat: fix build

2023-01-11 Thread Thomas Monjalon
04/01/2023 12:56, Akhil Goyal: > > On Fri, Dec 30, 2022 at 10:07:28PM +0100, Thomas Monjalon wrote: > > > When trying to compile on a fresh system, I hit this error: > > > > > > intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined > > > 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE

Re: [PATCH] crypto/qat: fix build for generic x86 with GCC 12

2023-01-10 Thread Bruce Richardson
On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote: > Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12"). > The issue appears when building with the "generic" target we have in > devtools/test-meson-builds.sh. > > Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb f

RE: [EXT] Re: [PATCH] crypto/qat: fix build

2023-01-04 Thread Akhil Goyal
> On Fri, Dec 30, 2022 at 10:07:28PM +0100, Thomas Monjalon wrote: > > When trying to compile on a fresh system, I hit this error: > > > > intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined > > 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE > > In file included from drivers/crypto/

Re: [PATCH] crypto/qat: fix build

2022-12-30 Thread Tyler Retzlaff
On Fri, Dec 30, 2022 at 10:07:28PM +0100, Thomas Monjalon wrote: > When trying to compile on a fresh system, I hit this error: > > intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined > 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE > In file included from drivers/crypto/qat/qat_sym