Re: [PATCH] cmdline: configure input buffer size

2024-05-01 Thread Bruce Richardson
On Wed, May 01, 2024 at 06:56:37PM +0300, Etelson, Gregory wrote: > Hello Stephen, > > > > > Basic question, what would be the impact of increasing the default from > > > > 512 > > > > to 1k or 2k? Do we get a large memory footprint increase, or is it just > > > > an > > > > extra 1 or 2k of mem

Re: [PATCH] cmdline: configure input buffer size

2024-05-01 Thread Etelson, Gregory
Hello Stephen, Basic question, what would be the impact of increasing the default from 512 to 1k or 2k? Do we get a large memory footprint increase, or is it just an extra 1 or 2k of memory used? /Bruce Increasing the RDLINE_BUF_SIZE size will also increase application memory usage. However,

Re: [PATCH] cmdline: configure input buffer size

2024-05-01 Thread Stephen Hemminger
On Wed, 1 May 2024 13:06:47 +0300 (IDT) "Etelson, Gregory" wrote: > > Basic question, what would be the impact of increasing the default from 512 > > to 1k or 2k? Do we get a large memory footprint increase, or is it just an > > extra 1 or 2k of memory used? > > > > /Bruce > > > > Increasing t

Re: [PATCH] cmdline: configure input buffer size

2024-05-01 Thread Etelson, Gregory
Hello Bruce, Application can set custom cmdline size during DPDK configuration: `meson setup ... -Dc_args='-DRDLINE_CUSTOM_BUF_SIZE=4096' ...` Signed-off-by: Gregory Etelson --- Basic question, what would be the impact of increasing the default from 512 to 1k or 2k? Do we get a large memory

Re: [PATCH] cmdline: configure input buffer size

2024-05-01 Thread Bruce Richardson
On Wed, May 01, 2024 at 08:26:59AM +0300, Gregory Etelson wrote: > DPDK defines cmdline input buffer size to 512 characters. > That buffer size can be too small for long application input. > For example, the following flow template API testpmd command is 444 > bytes long: > ``` > flow queue 0 creat