Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-16 Thread Thomas Monjalon
16/03/2023 11:46, Ferruh Yigit: > On 3/16/2023I 9:19 AM, Dmitry Kozlyuk wrote: > > On Thu, Mar 16, 2023 at 4:11 AM fengchengwen > > wrote: > >> Because we have no API to know the PMD whether impl specific ops, we could > >> only knowed by invoking. > >> Except above impl, I also consider the oth

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-16 Thread Ferruh Yigit
On 3/16/2023I 9:19 AM, Dmitry Kozlyuk wrote: > On Thu, Mar 16, 2023 at 4:11 AM fengchengwen wrote: >> Because we have no API to know the PMD whether impl specific ops, we could >> only knowed by invoking. >> Except above impl, I also consider the other two: >> 1. just invoke rte_eth_dev_priv_dump

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-16 Thread fengchengwen
On 2023/3/16 17:19, Dmitry Kozlyuk wrote: > On Thu, Mar 16, 2023 at 4:11 AM fengchengwen wrote: >> Because we have no API to know the PMD whether impl specific ops, we could >> only knowed by invoking. >> Except above impl, I also consider the other two: >> 1. just invoke rte_eth_dev_priv_dump wi

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-16 Thread fengchengwen
On 2023/3/16 15:55, Thomas Monjalon wrote: > 16/03/2023 02:10, fengchengwen: >> On 2023/3/15 18:12, Ferruh Yigit wrote: >>> On 3/15/2023 2:33 AM, Chengwen Feng wrote: This patch adds dump private info in 'show port info [port_id]' cmd. Signed-off-by: Chengwen Feng --- app

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-16 Thread Dmitry Kozlyuk
On Thu, Mar 16, 2023 at 4:11 AM fengchengwen wrote: > Because we have no API to know the PMD whether impl specific ops, we could > only knowed by invoking. > Except above impl, I also consider the other two: > 1. just invoke rte_eth_dev_priv_dump without previous printf("Device private > info")

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-16 Thread Thomas Monjalon
16/03/2023 02:10, fengchengwen: > On 2023/3/15 18:12, Ferruh Yigit wrote: > > On 3/15/2023 2:33 AM, Chengwen Feng wrote: > >> This patch adds dump private info in 'show port info [port_id]' cmd. > >> > >> Signed-off-by: Chengwen Feng > >> --- > >> app/test-pmd/config.c | 5 + > >> 1 file chan

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-15 Thread fengchengwen
On 2023/3/15 18:12, Ferruh Yigit wrote: > On 3/15/2023 2:33 AM, Chengwen Feng wrote: >> This patch adds dump private info in 'show port info [port_id]' cmd. >> >> Signed-off-by: Chengwen Feng >> --- >> app/test-pmd/config.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/app/test

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-15 Thread Ferruh Yigit
On 3/15/2023 2:33 AM, Chengwen Feng wrote: > This patch adds dump private info in 'show port info [port_id]' cmd. > > Signed-off-by: Chengwen Feng > --- > app/test-pmd/config.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 01

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-15 Thread Singh, Aman Deep
On 3/15/2023 8:03 AM, Chengwen Feng wrote: This patch adds dump private info in 'show port info [port_id]' cmd. Signed-off-by: Chengwen Feng Acked-by: Aman Singh --- app/test-pmd/config.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/con