RE: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-10-04 Thread Konstantin Ananyev
Hi Bruce, > On Tue, Oct 04, 2022 at 11:15:19AM +0200, Morten Brørup wrote: > > > From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > > > Sent: Monday, 3 October 2022 22.02 > > > > [...] > > > > > The functionality provided is very useful, and the implementation is > > > clever in the way it

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-10-04 Thread Mattias Rönnblom
On 2022-10-04 13:57, Bruce Richardson wrote: > On Tue, Oct 04, 2022 at 11:15:19AM +0200, Morten Brørup wrote: >>> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] >>> Sent: Monday, 3 October 2022 22.02 >> >> [...] >> >>> The functionality provided is very useful, and the implementation is >>>

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-10-04 Thread Bruce Richardson
On Tue, Oct 04, 2022 at 11:15:19AM +0200, Morten Brørup wrote: > > From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > > Sent: Monday, 3 October 2022 22.02 > > [...] > > > The functionality provided is very useful, and the implementation is > > clever in the way it doesn't require any applica

RE: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-10-04 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Monday, 3 October 2022 22.02 [...] > The functionality provided is very useful, and the implementation is > clever in the way it doesn't require any application modifications. > But, > a clever, useful brittle hack is still a brittle

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-10-03 Thread Mattias Rönnblom
On 2022-10-01 16:17, Konstantin Ananyev wrote: Hi Kevin, Currently, there is no way to measure lcore poll busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core polling busyness. The poll busyness is

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-10-01 Thread Konstantin Ananyev
Hi Kevin, Currently, there is no way to measure lcore poll busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core polling busyness. The poll busyness is calculated by relying on the fact that most DP

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-30 Thread Mattias Rönnblom
On 2022-09-14 11:29, Kevin Laatz wrote: From: Anatoly Burakov Currently, there is no way to measure lcore poll busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core polling busyness. I think it's more f

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-30 Thread Jerin Jacob
On Thu, Sep 29, 2022 at 6:11 PM Kevin Laatz wrote: > > > > >> 2. Ring does not have callback support, meaning pipelined applications > >> could not report lcore poll busyness telemetry with this approach. > > That's another big concern that I have: > > Why you consider that all rings will be used

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-29 Thread Kevin Laatz
On 26/09/2022 10:37, Konstantin Ananyev wrote: Hi Kevin, Currently, there is no way to measure lcore poll busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core polling busyness. The poll busyness is calc

RE: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-26 Thread Konstantin Ananyev
Hi Kevin, > >> Currently, there is no way to measure lcore poll busyness in a passive way, > >> without any modifications to the application. This patch adds a new EAL API > >> that will be able to passively track core polling busyness. > >> > >> The poll busyness is calculated by relying on the

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-22 Thread Kevin Laatz
On 19/09/2022 11:19, Konstantin Ananyev wrote: Hi everyone, From: Anatoly Burakov Currently, there is no way to measure lcore poll busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core polling busyness.

RE: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-19 Thread Konstantin Ananyev
Hi everyone, > > From: Anatoly Burakov > > Currently, there is no way to measure lcore poll busyness in a passive way, > without any modifications to the application. This patch adds a new EAL API > that will be able to passively track core polling busyness. > > The poll busyness is calculated

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-16 Thread Kevin Laatz
On 14/09/2022 15:30, Stephen Hemminger wrote: On Wed, 14 Sep 2022 10:29:26 +0100 Kevin Laatz wrote: +struct lcore_poll_telemetry { + int poll_busyness; + /**< Calculated poll busyness (gets set/returned by the API) */ + int raw_poll_busyness; + /**< Calculated poll busy

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-09-14 Thread Stephen Hemminger
On Wed, 14 Sep 2022 10:29:26 +0100 Kevin Laatz wrote: > +struct lcore_poll_telemetry { > + int poll_busyness; > + /**< Calculated poll busyness (gets set/returned by the API) */ > + int raw_poll_busyness; > + /**< Calculated poll busyness times 100. */ > + uint64_t interval_ts