RE: [PATCH v7] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-13 Thread Hu, Jiayu
cause of window compiler errors, defining the two functions as static inline in gro_tcp_internal.h may be a solution. Thanks, Jiayu From: kumaraparameshwaran rathinavel Sent: Wednesday, June 14, 2023 11:43 AM To: Hu, Jiayu Cc: dev@dpdk.org Subject: Re: [PATCH v7] gro : ipv6 changes to support

Re: [PATCH v7] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-13 Thread kumaraparameshwaran rathinavel
On Tue, Jun 13, 2023 at 7:56 AM Hu, Jiayu wrote: > Hi Kumara, > > Overall, the patch looks good to me. But you need to update the doc and > there > are some minor changes needed to be made. Please see replies inline. > >> Thanks Jiayu. I see some linking errors for windows. It was a for >> ineser

RE: [PATCH v7] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-12 Thread Hu, Jiayu
Hi Kumara, Overall, the patch looks good to me. But you need to update the doc and there are some minor changes needed to be made. Please see replies inline. After all comments are addressed, you can add "Reviewed-by: Jiayu Hu ". Thanks, Jiayu > -Original Message- > From: Kumara Param