Re: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-03 Thread David Marchand
c: dev@dpdk.org; Yang, Qiming ; > > sta...@dpdk.org > > Subject: Re: [PATCH v5] net/i40e: rework maximum frame size configuration > > > > On Thu, Feb 2, 2023 at 2:24 PM David Marchand > > wrote: > > > > > > On Thu, Feb 2, 202

RE: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-03 Thread Yang, Qiming
> -Original Message- > From: David Marchand > Sent: Thursday, February 2, 2023 9:49 PM > To: Su, Simei ; Zhang, Yuying > ; Xing, Beilei ; Zhang, Qi Z > > Cc: dev@dpdk.org; Yang, Qiming ; > sta...@dpdk.org > Subject: Re: [PATCH v5] net/i40e: rework maxim

RE: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-02 Thread Su, Simei
Hi David, > -Original Message- > From: David Marchand > Sent: Thursday, February 2, 2023 9:24 PM > To: Su, Simei > Cc: Xing, Beilei ; Zhang, Yuying > ; dev@dpdk.org; Zhang, Qi Z > ; Yang, Qiming ; > sta...@dpdk.org > Subject: Re: [PATCH v5] net/i40e

RE: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-02 Thread Su, Simei
Hi David, > -Original Message- > From: David Marchand > Sent: Thursday, February 2, 2023 8:56 PM > To: Su, Simei ; Zhang, Qi Z > Cc: Xing, Beilei ; Zhang, Yuying > ; dev@dpdk.org; Yang, Qiming > ; sta...@dpdk.org > Subject: Re: [PATCH v5] net/i40e: r

Re: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-02 Thread David Marchand
On Thu, Feb 2, 2023 at 2:24 PM David Marchand wrote: > > On Thu, Feb 2, 2023 at 1:37 PM Simei Su wrote: > > @@ -2467,8 +2466,16 @@ i40e_dev_start(struct rte_eth_dev *dev) > > "please call hierarchy_commit() " > > "before starting the port");

Re: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-02 Thread David Marchand
On Thu, Feb 2, 2023 at 1:37 PM Simei Su wrote: > @@ -2467,8 +2466,16 @@ i40e_dev_start(struct rte_eth_dev *dev) > "please call hierarchy_commit() " > "before starting the port"); > > - max_frame_size = dev->data->mtu + I40E_ETH_OVERHEAD

Re: [PATCH v5] net/i40e: rework maximum frame size configuration

2023-02-02 Thread David Marchand
On Thu, Feb 2, 2023 at 1:37 PM Simei Su wrote: > > This patch reverts mentioned changes below to remove unnecessary link > status check and only moves max frame size configuration to dev_start. > Also, it sets the parameter "wait to complete" true to wait for complete > right after setting link up