RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-07-11 Thread Xia, Chenbo
re both vhost msg return code like > > > "RTE_VHOST_MSG_RESULT_XXX" and function return value. > > > I wonder if it is better to use two different variable to make it easy > > > to read. > > > > By saying 'function return value', y

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-07-11 Thread Pei, Andy
X ; > dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; He, > Xingguang ; sta...@dpdk.org > Subject: RE: [PATCH v3] vhost: fix deadlock when message handling failed > > > -Original Message- > > From: Pei, Andy > > Sent: Monday, July 11, 2022 4:42 PM > >

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-07-11 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, July 11, 2022 4:42 PM > To: Maxime Coquelin ; Ma, WenwuX > ; Xia, Chenbo ; dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; He, > Xingguang ; sta...@dpdk.org > Subject: RE: [PATCH v3] vhost: fix deadlock when

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-07-11 Thread Pei, Andy
> From: Maxime Coquelin > Sent: Tuesday, May 17, 2022 9:24 PM > To: Ma, WenwuX ; Xia, Chenbo > ; dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; He, > Xingguang ; sta...@dpdk.org > Subject: Re: [PATCH v3] vhost: fix deadlock when message handling failed >

Re: [PATCH v3] vhost: fix deadlock when message handling failed

2022-05-17 Thread Maxime Coquelin
On 5/7/22 15:27, Wenwu Ma wrote: In vhost_user_msg_handler(), if vhost message handling failed, we should check whether the queue is locked and release the lock before returning. Or, it will cause a deadlock later. Fixes: 7f31d4ea05ca ("vhost: fix lock on device readiness notification") Cc: s

Re: [PATCH v3] vhost: fix deadlock when message handling failed

2022-05-17 Thread David Marchand
On Sat, May 7, 2022 at 7:30 AM Wenwu Ma wrote: > > In vhost_user_msg_handler(), if vhost message handling > failed, we should check whether the queue is locked and > release the lock before returning. Or, it will cause a > deadlock later. > > Fixes: 7f31d4ea05ca ("vhost: fix lock on device readine

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-05-08 Thread Ling, WeiX
> -Original Message- > From: Wenwu Ma > Sent: Saturday, May 7, 2022 9:28 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; > He, Xingguang ; Ma, WenwuX > ; sta...@dpdk.org > Subject: [PATCH v3] vhost: fix deadlock when message handling failed

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-05-06 Thread Xia, Chenbo
> -Original Message- > From: Ma, WenwuX > Sent: Saturday, May 7, 2022 9:28 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; He, > Xingguang ; Ma, WenwuX ; > sta...@dpdk.org > Subject: [PATCH v3] vhost: fix deadlock when message handling fail