RE: [PATCH v3] app/testpmd: enable cli for programmable action

2023-10-06 Thread Zhang, Qi Z
> -Original Message- > From: Dumitrescu, Cristian > Sent: Friday, October 6, 2023 8:36 PM > To: Zhang, Qi Z ; Singh, Aman Deep > ; Zhang, Yuying > Cc: dev@dpdk.org; or...@nvidia.com; ferruh.yi...@amd.com > Subject: RE: [PATCH v3] app/testpmd: enable cli fo

RE: [PATCH v3] app/testpmd: enable cli for programmable action

2023-10-06 Thread Dumitrescu, Cristian
Hi Qi, > > +#define ACTION_PROG_NAME_SIZE_MAX 32 > +#define ACTION_PROG_ARG_NUM_MAX 16 > +#define ACTION_PROG_ARG_VALUE_SIZE_MAX 32 Let's be a bit more generous with some of these sizes, please. The action name might be hierarchical, i.e. include the control block and table path separated