Re: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-26 Thread Chas Williams
On 9/26/22 06:18, Konstantin Ananyev wrote: Hi everyone, Sorry for late reply. The main problem is hard to design a tx_prepare for bonding device: 1. as Chas Williams said, there maybe twice hash calc to get target slave     devices. 2. also more important, if the slave devices have cha

RE: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-26 Thread Konstantin Ananyev
Hi everyone, Sorry for late reply. > > The main problem is hard to design a tx_prepare for bonding device: > > 1. as Chas Williams said, there maybe twice hash calc to get target > > slave > >     devices. > > 2. also more important, if the slave devices have changes(e.g.

Re: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-25 Thread Chas Williams
On 9/21/22 22:12, fengchengwen wrote: On 2022/9/20 7:02, Chas Williams wrote: On 9/19/22 10:07, Konstantin Ananyev wrote: On 9/16/22 22:35, fengchengwen wrote: Hi Chas, On 2022/9/15 0:59, Chas Williams wrote: On 9/13/22 20:46, fengchengwen wrote: The main problem is hard to desig

Re: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-21 Thread fengchengwen
On 2022/9/20 7:02, Chas Williams wrote: > > > On 9/19/22 10:07, Konstantin Ananyev wrote: >> >>> >>> On 9/16/22 22:35, fengchengwen wrote: Hi Chas, On 2022/9/15 0:59, Chas Williams wrote: > On 9/13/22 20:46, fengchengwen wrote: >> >> The main problem is hard to desig

Re: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-19 Thread Chas Williams
On 9/19/22 10:07, Konstantin Ananyev wrote: On 9/16/22 22:35, fengchengwen wrote: Hi Chas, On 2022/9/15 0:59, Chas Williams wrote: On 9/13/22 20:46, fengchengwen wrote: The main problem is hard to design a tx_prepare for bonding device: 1. as Chas Williams said, there maybe twice hash

RE: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-19 Thread Konstantin Ananyev
> > On 9/16/22 22:35, fengchengwen wrote: > > Hi Chas, > > > > On 2022/9/15 0:59, Chas Williams wrote: > >> On 9/13/22 20:46, fengchengwen wrote: > >>> > >>> The main problem is hard to design a tx_prepare for bonding device: > >>> 1. as Chas Williams said, there maybe twice hash calc to get targ

Re: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-17 Thread Chas Williams
On 9/16/22 22:35, fengchengwen wrote: Hi Chas, On 2022/9/15 0:59, Chas Williams wrote: On 9/13/22 20:46, fengchengwen wrote: The main problem is hard to design a tx_prepare for bonding device: 1. as Chas Williams said, there maybe twice hash calc to get target slave     devices. 2. also m

Re: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-14 Thread Chas Williams
On 9/13/22 20:46, fengchengwen wrote: The main problem is hard to design a tx_prepare for bonding device: 1. as Chas Williams said, there maybe twice hash calc to get target slave devices. 2. also more important, if the slave devices have changes(e.g. slave device link down or remove), a

Re: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-13 Thread Chas Williams
On 9/13/22 06:22, Ferruh Yigit wrote: > On 7/25/2022 5:08 AM, Chengwen Feng wrote: > > > I assume intention is to make this as transparent as possible to the > user, that is why you are using a wrapper that combines > `rte_eth_tx_prepare()` & `rte_eth_tx_burst()` APIs. But for other PMDs > `rte_eth

Re: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-13 Thread Ferruh Yigit
On 7/25/2022 5:08 AM, Chengwen Feng wrote: Normally, to use the HW offloads capability (e.g. checksum and TSO) in the Tx direction, the application needs to call rte_eth_dev_prepare to do some adjustment with the packets before sending them (e.g. processing pseudo headers when Tx checksum offlo