Re: [PATCH v2 1/2] common/mlx5: fix build disabling

2022-11-02 Thread Thomas Monjalon
02/11/2022 14:14, Bruce Richardson: > On Wed, Nov 02, 2022 at 01:29:49PM +0100, Thomas Monjalon wrote: > > 02/11/2022 13:10, Bruce Richardson: > > > On Sun, Oct 30, 2022 at 09:27:21AM +0100, Thomas Monjalon wrote: > > > > +if not ('mlx5' in common_drivers) > > > > > > While this is fine as-is, I t

Re: [PATCH v2 1/2] common/mlx5: fix build disabling

2022-11-02 Thread Bruce Richardson
On Wed, Nov 02, 2022 at 01:29:49PM +0100, Thomas Monjalon wrote: > 02/11/2022 13:10, Bruce Richardson: > > On Sun, Oct 30, 2022 at 09:27:21AM +0100, Thomas Monjalon wrote: > > > If the dependency common/mlx5 is explicitly disabled, > > > but net/mlx5 is not explicitly disabled, > > > Meson will rea

Re: [PATCH v2 1/2] common/mlx5: fix build disabling

2022-11-02 Thread Thomas Monjalon
02/11/2022 13:10, Bruce Richardson: > On Sun, Oct 30, 2022 at 09:27:21AM +0100, Thomas Monjalon wrote: > > If the dependency common/mlx5 is explicitly disabled, > > but net/mlx5 is not explicitly disabled, > > Meson will read the full recipe of net/mlx5 > > and will fail when accessing a variable f

Re: [PATCH v2 1/2] common/mlx5: fix build disabling

2022-11-02 Thread Bruce Richardson
On Sun, Oct 30, 2022 at 09:27:21AM +0100, Thomas Monjalon wrote: > If the dependency common/mlx5 is explicitly disabled, > but net/mlx5 is not explicitly disabled, > Meson will read the full recipe of net/mlx5 > and will fail when accessing a variable from common/mlx5: > drivers/net/mlx5/meson.buil

RE: [PATCH v2 1/2] common/mlx5: fix build disabling

2022-10-30 Thread Matan Azrad
> If the dependency common/mlx5 is explicitly disabled, but net/mlx5 is not > explicitly disabled, Meson will read the full recipe of net/mlx5 and will fail > when accessing a variable from common/mlx5: > drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable > "mlx5_config". > > The soluti