Re: [PATCH] vhost: fix vring enable with VDPA

2023-03-06 Thread Maxime Coquelin
On 3/2/23 10:48, David Marchand wrote: For VDPA devices, vq are not locked once the device has been configured. But we need to hold the vq lock to check if vhost async is enabled. Combining VDPA and vhost async does not seem to make much sense, so prevent this combination, and only assert the

RE: [PATCH] vhost: fix vring enable with VDPA

2023-03-03 Thread Ali Alnubani
> -Original Message- > From: David Marchand > Sent: Thursday, March 2, 2023 11:48 AM > To: dev@dpdk.org > Cc: Semion Simma ; Yajun Wu ; > Maxime Coquelin ; Chenbo Xia > ; Morten Brørup > Subject: [PATCH] vhost: fix vring enable with VDPA > > For VDPA devices, vq are not locked once the d

RE: [PATCH] vhost: fix vring enable with VDPA

2023-03-02 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Thursday, March 2, 2023 5:48 PM > To: dev@dpdk.org > Cc: ssi...@nvidia.com; yaj...@nvidia.com; Maxime Coquelin > ; Xia, Chenbo ; Morten > Brørup > Subject: [PATCH] vhost: fix vring enable with VDPA > > For VDPA devices, vq are not locke

Re: [PATCH] vhost: fix vring enable with VDPA

2023-03-02 Thread Maxime Coquelin
On 3/2/23 10:48, David Marchand wrote: For VDPA devices, vq are not locked once the device has been configured. But we need to hold the vq lock to check if vhost async is enabled. Combining VDPA and vhost async does not seem to make much sense, so prevent this combination, and only assert the