Re: [PATCH] net/ena: revert redefining memcpy

2024-09-21 Thread Ferruh Yigit
On 9/12/2024 6:12 AM, Tyler Retzlaff wrote: > On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote: >> Redefining memcpy as rte_memcpy has no performance gain on >> current compilers, and introduced bugs like this one where >> rte_memcpy() will be detected as referencing past the desti

RE: [PATCH] net/ena: revert redefining memcpy

2024-09-16 Thread Brandes, Shai
Thanks for the clarification. We are okay to move forward with the revert. בתאריך 16 בספט׳ 2024 18:12,‏ Stephen Hemminger כתב: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

RE: [PATCH] net/ena: revert redefining memcpy

2024-09-15 Thread Brandes, Shai
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, September 12, 2024 11:20 AM > To: Tyler Retzlaff ; Stephen Hemminger > ; Brandes, Shai > Cc: dev@dpdk.org; Schmeilin, Evgeny ; Beider, Ron > ; Bernstein, Amit ; > Atrash, Wajeeh ; Chauskin, Igor > ; Michal Krawczyk ; Artur Roje

RE: [PATCH] net/ena: revert redefining memcpy

2024-09-12 Thread Brandes, Shai
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, September 12, 2024 11:20 AM > To: Tyler Retzlaff ; Stephen Hemminger > ; Brandes, Shai > Cc: dev@dpdk.org; Schmeilin, Evgeny ; Beider, Ron > ; Bernstein, Amit ; > Atrash, Wajeeh ; Chauskin, Igor > ; Michal Krawczyk ; Artur Roje

Re: [PATCH] net/ena: revert redefining memcpy

2024-09-12 Thread Ferruh Yigit
On 9/12/2024 6:12 AM, Tyler Retzlaff wrote: > On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote: >> Redefining memcpy as rte_memcpy has no performance gain on >> current compilers, and introduced bugs like this one where >> rte_memcpy() will be detected as referencing past the desti

Re: [PATCH] net/ena: revert redefining memcpy

2024-09-11 Thread Tyler Retzlaff
On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote: > Redefining memcpy as rte_memcpy has no performance gain on > current compilers, and introduced bugs like this one where > rte_memcpy() will be detected as referencing past the destination. > > Bugzilla ID: 1510 > Fixes: 142778b37

RE: [PATCH] net/ena: revert redefining memcpy

2024-08-13 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Redefining memcpy as rte_memcpy has no performance gain on > current compilers, and introduced bugs like this one where > rte_memcpy() will be detected as referencing past the destination. > > Bugzilla ID: 1510 > Fixes: 142778b3702

RE: [PATCH] net/ena: revert redefining memcpy

2024-08-12 Thread Wathsala Wathawana Vithanage
> Subject: [PATCH] net/ena: revert redefining memcpy > > Redefining memcpy as rte_memcpy has no performance gain on current > compilers, and introduced bugs like this one where > rte_memcpy() will be detected as referencing past the destination. > > Bugzilla ID: 1510 > Fixes: 142778b3702a ("net