RE: [PATCH] mlx5: initially reading xstats does not cause seg fault

Hi, Huzaifa "n" - is the parameter of the mlx5_xstats_get() routine, provided by caller. We should not change this - it specified the size of "struct rte_eth_xstat *stats " array. With best regards, Slava > -Original Message- > From: huzaifa.rahman > Sent: четверг, 18 августа 2022 г. 1

RE: [PATCH] mlx5: initially reading xstats does not cause seg fault

Hi, Huzaifa Could you, please, format commit message with capitals in the sentence beginnings? And explanation can be less wordy a little bit. With best regards, Slava > -Original Message- > From: huzaifa.rahman > Sent: четверг, 18 августа 2022 г. 15:30 > To: Matan Azrad > Cc: dev@dpdk

Re: [PATCH] mlx5: initially reading xstats does not cause seg fault

Hello, On 11/10/22 11:07, Huzaifa Rahman wrote: Hi, Is there any other work/changes required for this patch to be submitted? Thanks On Thu, Sep 22, 2022 at 3:39 PM Huzaifa Rahman wrote: The bugzilla ID of this bug is 701: https://bugs.dpdk.org/show_bug.cgi?id=701 On Tue, Aug 23, 2022 at

Re: [PATCH] mlx5: initially reading xstats does not cause seg fault

Hi, Is there any other work/changes required for this patch to be submitted? Thanks On Thu, Sep 22, 2022 at 3:39 PM Huzaifa Rahman wrote: > The bugzilla ID of this bug is 701: > https://bugs.dpdk.org/show_bug.cgi?id=701 > > On Tue, Aug 23, 2022 at 12:33 PM Kamil Vojanec wrote: > >> On 8/18/2

Re: [PATCH] mlx5: initially reading xstats does not cause seg fault

The bugzilla ID of this bug is 701: https://bugs.dpdk.org/show_bug.cgi?id=701 On Tue, Aug 23, 2022 at 12:33 PM Kamil Vojanec wrote: > On 8/18/22 14:30, huzaifa.rahman wrote: > > Bugzilla ID: 296 > > the size of counters array in mlx5_xstats_get() was smaller > than the memory we are setting for

Re: [PATCH] mlx5: initially reading xstats does not cause seg fault

On 8/18/22 14:30, huzaifa.rahman wrote: Bugzilla ID: 296 the size of counters array in mlx5_xstats_get() was smaller than the memory we are setting for this array in mlx5_os_read_dev_counters(). due to which the extra memory is corrupted and thus corrupting the seemingly unrelated variables. th