RE: [PATCH] failsafe: fix segfault on hotplug event

2022-11-18 Thread Konstantin Ananyev
Hi Luc, > > Hi Konstantin, > > > > > It is not recommended way to update rte_eth_fp_ops[] contents directly. > > > There are eth_dev_fp_ops_setup()/ eth_dev_fp_ops_reset() that supposed > > > to be used for that. > > > > Good to know. I see another fix that was made in a different PMD that > >

Re: [PATCH] failsafe: fix segfault on hotplug event

2022-11-16 Thread Stephen Hemminger
On Wed, 16 Nov 2022 16:51:59 -0500 Luc Pelletier wrote: > Hi Konstantin, > > > It is not recommended way to update rte_eth_fp_ops[] contents directly. > > There are eth_dev_fp_ops_setup()/ eth_dev_fp_ops_reset() that supposed > > to be used for that. > > Good to know. I see another fix that w

Re: [PATCH] failsafe: fix segfault on hotplug event

2022-11-16 Thread Luc Pelletier
Hi Konstantin, > It is not recommended way to update rte_eth_fp_ops[] contents directly. > There are eth_dev_fp_ops_setup()/ eth_dev_fp_ops_reset() that supposed > to be used for that. Good to know. I see another fix that was made in a different PMD that does exactly the same thing: https://gith

RE: [PATCH] failsafe: fix segfault on hotplug event

2022-11-16 Thread Konstantin Ananyev
> When the failsafe PMD encounters a hotplug event, it switches its rx/tx > functions to "safe" ones that validate the sub-device's rx/tx functions > before calling them. It switches the rx/tx functions by changing the > function pointers in the rte_eth_dev structure. > > Following commit 7a0