Hi Gowri,
On 2/28/25 2:59 PM, Gowrishankar Muthukrishnan wrote:
Hi Maxime,
Before your series arrived, we were wondering if we should not deprecate Vhost
crypto as it was not really maintained and we had no identified user.
Since it seems you are going to use it, which is great, would you co
Hi David,
> >
> > It is due to local vc_req that is passed to func that requires iotlb
> > lock In vc_req->vq. Even though vc_req->vq is locked vq, GCC does not allow
> > it,
> as I understand.
>
> *cough* clang.
>
> >
> > vc_req = &data_req;
> > vc_req->desc_idx = desc_idx;
> >
Hi Maxime,
>
> Before your series arrived, we were wondering if we should not deprecate Vhost
> crypto as it was not really maintained and we had no identified user.
>
> Since it seems you are going to use it, which is great, would you commit to
> make
> the necessary changes to make it reliabl
Hi Gowri,
On 2/28/25 9:48 AM, David Marchand wrote:
On Thu, Feb 27, 2025 at 7:07 PM Gowrishankar Muthukrishnan
wrote:
Ha, and also you should be able to remove:
__rte_no_thread_safety_analysis /* FIXME: requires iotlb_lock? */ in
vhost_crypto_process_one_req() once implemented.
Removing it
On Thu, Feb 27, 2025 at 7:07 PM Gowrishankar Muthukrishnan
wrote:
> > > Ha, and also you should be able to remove:
> > > __rte_no_thread_safety_analysis /* FIXME: requires iotlb_lock? */ in
> > > vhost_crypto_process_one_req() once implemented.
> > >
> >
> Removing it would break compilation for t
> >
> > Ha, and also you should be able to remove:
> > __rte_no_thread_safety_analysis /* FIXME: requires iotlb_lock? */ in
> > vhost_crypto_process_one_req() once implemented.
> >
>
Removing it would break compilation for thread safety flag.
http://mails.dpdk.org/archives/test-report/2025-Februar
Hi Maxime,
> >
> > You should only unlock at the end of the function, otherwise there is
> > not much protection.
>
> Ha, and also you should be able to remove:
> __rte_no_thread_safety_analysis /* FIXME: requires iotlb_lock? */ in
> vhost_crypto_process_one_req() once implemented.
>
Ack.
Thank
On 2/27/25 10:15 AM, Maxime Coquelin wrote:
Hi Gowri,
Thanks for the change, but I think there is an issue with the locking,
more below:
On 2/26/25 7:43 PM, Gowrishankar Muthukrishnan wrote:
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
worker thread should not try
Hi Gowri,
Thanks for the change, but I think there is an issue with the locking,
more below:
On 2/26/25 7:43 PM, Gowrishankar Muthukrishnan wrote:
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
worker thread should not try to fetch crypto op, which would lead to
memory f
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
worker thread should not try to fetch crypto op, which would lead to
memory fault.
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: sta...@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan
Acked-b
10 matches
Mail list logo
