[dpdk-dev] weak functions in some drivers

2016-07-14 Thread Zoltan Kiss
gt;>> To: Elo, Matias (Nokia - FI/Espoo) ; >>> dev at dpdk.org >>> Cc: ferruh.yigit at intel.com; damarion at cisco.com >>> Subject: Re: [dpdk-dev] weak functions in some drivers >>> >>> On 01/07/2016 10:42, Elo, Matias (Nokia - FI/Espoo) wrote: &

[dpdk-dev] weak functions in some drivers

2016-07-01 Thread Sergio Gonzalez Monroy
t;> Cc: ferruh.yigit at intel.com; damarion at cisco.com >> Subject: Re: [dpdk-dev] weak functions in some drivers >> >> On 01/07/2016 10:42, Elo, Matias (Nokia - FI/Espoo) wrote: >>>>>>>> What is not clear to me is motivation to use weak here instead

[dpdk-dev] weak functions in some drivers

2016-07-01 Thread Sergio Gonzalez Monroy
On 01/07/2016 10:42, Elo, Matias (Nokia - FI/Espoo) wrote: >> What is not clear to me is motivation to use weak here instead of simply >>> using >CONFIG_RTE_I40E_INC_VECTOR >> macro to exclude stubs in i40e_rxtx.c. It will make library smaller and >> avoid >>> issues like this one

[dpdk-dev] weak functions in some drivers

2016-07-01 Thread Elo, Matias (Nokia - FI/Espoo)
> -Original Message- > From: Sergio Gonzalez Monroy [mailto:sergio.gonzalez.monroy at intel.com] > Sent: Friday, July 01, 2016 1:05 PM > To: Elo, Matias (Nokia - FI/Espoo) ; > dev at dpdk.org > Cc: ferruh.yigit at intel.com; damarion at cisco.com > Subject: Re: [dpdk-d

[dpdk-dev] weak functions in some drivers

2016-07-01 Thread Elo, Matias (Nokia - FI/Espoo)
> > >>> What is not clear to me is motivation to use weak here instead of simply > > using >CONFIG_RTE_I40E_INC_VECTOR > > >>> macro to exclude stubs in i40e_rxtx.c. It will make library smaller and > > >>> avoid > > issues like this one > > >>> which are quite hard to troubleshoot. > > >> Since t

[dpdk-dev] weak functions in some drivers

2016-06-30 Thread Sergio Gonzalez Monroy
On 29/06/2016 14:26, Elo, Matias (Nokia - FI/Espoo) wrote: >>> What is not clear to me is motivation to use weak here instead of simply >>> using >CONFIG_RTE_I40E_INC_VECTOR >>> macro to exclude stubs in i40e_rxtx.c. It will make library smaller and >>> avoid issues like this one >>> which are qu

[dpdk-dev] weak functions in some drivers

2016-06-30 Thread Elo, Matias (Nokia - FI/Espoo)
> >>> What is not clear to me is motivation to use weak here instead of simply > using >CONFIG_RTE_I40E_INC_VECTOR > >>> macro to exclude stubs in i40e_rxtx.c. It will make library smaller and > >>> avoid > issues like this one > >>> which are quite hard to troubleshoot. > >> Since this issue seen

[dpdk-dev] weak functions in some drivers

2016-06-29 Thread Elo, Matias (Nokia - FI/Espoo)
>> What is not clear to me is motivation to use weak here instead of simply >> using >CONFIG_RTE_I40E_INC_VECTOR >> macro to exclude stubs in i40e_rxtx.c. It will make library smaller and >> avoid issues like this one >> which are quite hard to troubleshoot. > >Since this issue seen in fd.io, I d

[dpdk-dev] weak functions in some drivers

2016-06-27 Thread Ferruh Yigit
On 6/21/2016 4:01 PM, Damjan Marion (damarion) wrote: > > Hello, > ... > > What is not clear to me is motivation to use weak here instead of simply > using CONFIG_RTE_I40E_INC_VECTOR > macro to exclude stubs in i40e_rxtx.c. It will make library smaller and avoid > issues like this one > whic

[dpdk-dev] weak functions in some drivers

2016-06-21 Thread Ferruh Yigit
Hi Damjan, On 6/21/2016 4:01 PM, Damjan Marion (damarion) wrote: > > Hello, > > We just spent few hours troubleshooting why vPMD is not working > in i40e driver. Conclusion was that problem is caused by linker > linking the wrong instance of the i40e_rx_vec_dev_conf_condition_check(...). > > T

[dpdk-dev] weak functions in some drivers

2016-06-21 Thread Damjan Marion (damarion)
> On 21 Jun 2016, at 09:01, Ferruh Yigit wrote: > > Hi Damjan, > > On 6/21/2016 4:01 PM, Damjan Marion (damarion) wrote: >> >> Hello, >> >> We just spent few hours troubleshooting why vPMD is not working >> in i40e driver. Conclusion was that problem is caused by linker >> linking the wrong

[dpdk-dev] weak functions in some drivers

2016-06-21 Thread Damjan Marion (damarion)
Hello, We just spent few hours troubleshooting why vPMD is not working in i40e driver. Conclusion was that problem is caused by linker linking the wrong instance of the i40e_rx_vec_dev_conf_condition_check(...). That function is defined 2 times, once in i40e_rxtx.c and once in i40e_rxtx_vec.c.