[dpdk-dev] vhost-user technical isssues

2014-11-17 Thread Tetsuya Mukawa
Hi Xie, (2014/11/14 19:59), Xie, Huawei wrote: > I tested with latest qemu(with offset fix) in vhost app(not with test case), > unmap succeeds only when the size is aligned to 1GB(hugepage size). I appreciate for your testing. > Another important thing is could we do mmap(0, region[i].memory_si

[dpdk-dev] vhost-user technical isssues

2014-11-15 Thread Xie, Huawei
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Thursday, November 13, 2014 7:53 PM > To: Xie, Huawei; dev at dpdk.org > Cc: Long, Thomas > Subject: Re: vhost-user technical isssues > > Hi Xie, > > (2014/11/14 9:22), Xie, Huawei wrote: > >> I think so.

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Tetsuya Mukawa
Hi Lin, (2014/11/14 14:30), Linhaifeng wrote: > > On 2014/11/14 13:12, Tetsuya Mukawa wrote: >> ease try another value like 6000MB > i have try this value 6000MB.I can munmap success. > > you mmap with size "memory_size + memory_offset" should also munmap with this > size. > I appreciate for your

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Tetsuya Mukawa
Hi Lin, (2014/11/14 13:42), Linhaifeng wrote: > > On 2014/11/14 11:40, Tetsuya Mukawa wrote: >> Hi Lin, >> >> (2014/11/14 12:13), Linhaifeng wrote: >>> size should be same as mmap and >>> guest_mem -= (memory.regions[i].mmap_offset / sizeof(*guest_mem)); >>> >> Thanks. It should be. >> How about f

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Linhaifeng
On 2014/11/14 13:12, Tetsuya Mukawa wrote: > ease try another value like 6000MB i have try this value 6000MB.I can munmap success. you mmap with size "memory_size + memory_offset" should also munmap with this size. -- Regards, Haifeng

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Tetsuya Mukawa
(2014/11/14 12:40), Tetsuya Mukawa wrote: > I am using 1GB hugepage size. > > $ sudo QTEST_HUGETLBFS_PATH=/mnt/huge make check > region=0, mmap=0x2aaac000, size=6291456000 > region=0, munmap=0x2aaac000, size=6291456000, ret=-1 << failed > > 6291456000 is not aligned by 1GB. > When I specify

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Linhaifeng
On 2014/11/14 11:40, Tetsuya Mukawa wrote: > Hi Lin, > > (2014/11/14 12:13), Linhaifeng wrote: >> >> size should be same as mmap and >> guest_mem -= (memory.regions[i].mmap_offset / sizeof(*guest_mem)); >> > > Thanks. It should be. > How about following patch? > > -

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Tetsuya Mukawa
Hi Lin, (2014/11/14 12:13), Linhaifeng wrote: > > size should be same as mmap and > guest_mem -= (memory.regions[i].mmap_offset / sizeof(*guest_mem)); > Thanks. It should be. How about following patch? --- diff --git a/tests/vhost-user-test.c b

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Tetsuya Mukawa
Hi Xie, (2014/11/14 9:22), Xie, Huawei wrote: >> I think so. I guess we need to consider 2 types of restarting. One is >> virtio-net driver restarting, the other is vhost-user backend >> restarting. But, so far, it's nice to start to think about virtio-net >> driver restarting first. Probably we n

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Tetsuya Mukawa
(2014/11/14 11:24), Linhaifeng wrote: > On 2014/11/14 9:28, Xie, Huawei wrote: > actually there may be two hugepage files created by qemu. one day i > create a 4G VM found qemu create 2 hugepage file and send them to > vhost-user. you can try to test it. That's the case. Bcasue I didn't think actu

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Tetsuya Mukawa
Hi Lin, (2014/11/13 15:30), Linhaifeng wrote: > On 2014/11/12 12:12, Tetsuya Mukawa wrote: >> Hi Xie, >> >> (2014/11/12 6:37), Xie, Huawei wrote: >>> Hi Tetsuya: >>> There are two major technical issues in my mind for vhost-user >>> implementation. >>> >>> 1) memory region map >>> Vhost-user pass

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Linhaifeng
On 2014/11/14 10:30, Tetsuya Mukawa wrote: > Hi Lin, > > (2014/11/13 15:30), Linhaifeng wrote: >> On 2014/11/12 12:12, Tetsuya Mukawa wrote: >>> Hi Xie, >>> >>> (2014/11/12 6:37), Xie, Huawei wrote: Hi Tetsuya: There are two major technical issues in my mind for vhost-user implem

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Xie, Huawei
- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Thursday, November 13, 2014 11:57 PM > To: Linhaifeng; Xie, Huawei > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] vhost-user technical isssues > > Hi Lin, > (2014/11/14 14:30), Linhaifeng wrote: > > > &g

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Linhaifeng
On 2014/11/14 9:28, Xie, Huawei wrote: > > >> -Original Message- >> From: Linhaifeng [mailto:haifeng.lin at huawei.com] >> Sent: Wednesday, November 12, 2014 11:28 PM >> To: Xie, Huawei; 'Tetsuya Mukawa'; dev at dpdk.org >> Subjec

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Xie, Huawei
> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Thursday, November 13, 2014 7:24 PM > To: Xie, Huawei; 'Tetsuya Mukawa'; dev at dpdk.org; lilijun; zhangkun > Subject: Re: [dpdk-dev] vhost-user technical isssues > > >

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Xie, Huawei
> -Original Message- > From: Linhaifeng [mailto:haifeng.lin at huawei.com] > Sent: Wednesday, November 12, 2014 11:28 PM > To: Xie, Huawei; 'Tetsuya Mukawa'; dev at dpdk.org > Subject: Re: [dpdk-dev] vhost-user technical isssues > > > > On 2014/

[dpdk-dev] vhost-user technical isssues

2014-11-14 Thread Xie, Huawei
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, November 11, 2014 9:13 PM > To: Xie, Huawei; dev at dpdk.org > Cc: Long, Thomas > Subject: Re: vhost-user technical isssues > > Hi Xie, > > (2014/11/12 6:37), Xie, Huawei wrote: > > Hi Tetsuya: >

[dpdk-dev] vhost-user technical isssues

2014-11-13 Thread Linhaifeng
On 2014/11/12 12:12, Tetsuya Mukawa wrote: > Hi Xie, > > (2014/11/12 6:37), Xie, Huawei wrote: >> Hi Tetsuya: >> There are two major technical issues in my mind for vhost-user >> implementation. >> >> 1) memory region map >> Vhost-user passes us file fd and offset for each memory region. >> Un

[dpdk-dev] vhost-user technical isssues

2014-11-13 Thread Linhaifeng
On 2014/11/12 5:37, Xie, Huawei wrote: > Hi Tetsuya: > There are two major technical issues in my mind for vhost-user implementation. > > 1) memory region map > Vhost-user passes us file fd and offset for each memory region. Unfortunately > the mmap offset is "very" wrong. I discovered this iss

[dpdk-dev] vhost-user technical isssues

2014-11-13 Thread Linhaifeng
On 2014/11/12 5:37, Xie, Huawei wrote: > Hi Tetsuya: > There are two major technical issues in my mind for vhost-user implementation. > > 1) memory region map > Vhost-user passes us file fd and offset for each memory region. Unfortunately > the mmap offset is "very" wrong. I discovered this iss

[dpdk-dev] vhost-user technical isssues

2014-11-12 Thread Tetsuya Mukawa
Hi Xie, (2014/11/12 6:37), Xie, Huawei wrote: > Hi Tetsuya: > There are two major technical issues in my mind for vhost-user implementation. > > 1) memory region map > Vhost-user passes us file fd and offset for each memory region. Unfortunately > the mmap offset is "very" wrong. I discovered thi

[dpdk-dev] vhost-user technical isssues

2014-11-11 Thread Xie, Huawei
Hi Tetsuya: There are two major technical issues in my mind for vhost-user implementation. 1) memory region map Vhost-user passes us file fd and offset for each memory region. Unfortunately the mmap offset is "very" wrong. I discovered this issue long time ago, and also found that I couldn't mma