[dpdk-dev] rte_ether: Driver-specific stats getting overwritten

2016-07-14 Thread Igor Ryzhov
Hello. How about deleting rx_nombuf from rte_eth_stats? Do you think this counter is necessary? It just shows enormous numbers in case of a lack of processing speed. But we already have imissed counter which shows real number of packets, dropped for the same reason. > 14 2016 ?., ? 16:37,

[dpdk-dev] rte_ether: Driver-specific stats getting overwritten

2016-07-14 Thread Remy Horton
On 14/07/2016 14:51, Igor Ryzhov wrote: [..] > How about deleting rx_nombuf from rte_eth_stats? Do you think this > counter is necessary? It just shows enormous numbers in case of a > lack of processing speed. But we already have imissed counter which > shows real number of packets, dropped for th

[dpdk-dev] rte_ether: Driver-specific stats getting overwritten

2016-07-14 Thread Thomas Monjalon
2016-07-14 14:29, Remy Horton: > 'noon, > > In rte_eth_stats_get() after doing the driver callout to populate struct > rte_eth_stats, the rx_nombuf member is overwritten with > dev->data->rx_mbuf_alloc_failed even though some drivers will have > filled rx_nombuf with a value from elsewhere. Thi

[dpdk-dev] rte_ether: Driver-specific stats getting overwritten

2016-07-14 Thread Remy Horton
'noon, In rte_eth_stats_get() after doing the driver callout to populate struct rte_eth_stats, the rx_nombuf member is overwritten with dev->data->rx_mbuf_alloc_failed even though some drivers will have filled rx_nombuf with a value from elsewhere. This makes assignment of rx_nombuf from withi