Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-14 Thread Thomas Monjalon
14/05/2018 16:10, Ferruh Yigit: > On 5/14/2018 11:19 AM, Shahaf Shuler wrote: > > Monday, May 14, 2018 1:00 PM, Ferruh Yigit: > >>> > >>> It depends on which PMD is used. Yes, it was no checks in ethdev before. > >>> If PMD does not support multi-segment Tx, some checksum or VLAN > >>> insertion of

Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 11:19 AM, Shahaf Shuler wrote: > Monday, May 14, 2018 1:00 PM, Ferruh Yigit: >>> >>> It depends on which PMD is used. Yes, it was no checks in ethdev before. >>> If PMD does not support multi-segment Tx, some checksum or VLAN >>> insertion offload, but application requests it and rely

Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-14 Thread Shahaf Shuler
Monday, May 14, 2018 1:00 PM, Ferruh Yigit: > > > > It depends on which PMD is used. Yes, it was no checks in ethdev before. > > If PMD does not support multi-segment Tx, some checksum or VLAN > > insertion offload, but application requests it and rely on it, it will > > result in invalid packets s

Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-14 Thread Ferruh Yigit
On 5/13/2018 6:30 AM, Shahaf Shuler wrote: > Friday, May 11, 2018 7:09 PM, Andrew Rybchenko: > > On 05/11/2018 05:22 PM, Ferruh Yigit wrote: > > I think we have the following options: > >   > > A. Rollback corresponding changes which remove checks from PMDs > >

Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-12 Thread Shahaf Shuler
Friday, May 11, 2018 7:09 PM, Andrew Rybchenko: On 05/11/2018 05:22 PM, Ferruh Yigit wrote: I think we have the following options: A. Rollback corresponding changes which remove checks from PMDs (at least some PMDs will be not affected). B. Fail configure if unsupported offload is requ

Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-11 Thread Andrew Rybchenko
On 05/11/2018 05:22 PM, Ferruh Yigit wrote: On 5/11/2018 8:07 AM, Andrew Rybchenko wrote: Hi all, I think that Rx/Tx offloads checks behaviour is inconsistent in next-net as of today. Consistency checks are removed from PMDs and substituted with error logs in ethdev. Yes. Basically applicat

Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 8:07 AM, Andrew Rybchenko wrote: > Hi all, > > I think that Rx/Tx offloads checks behaviour is inconsistent in next-net > as of today. > > Consistency checks are removed from PMDs and substituted with error logs > in ethdev. Yes. > Basically application which is not switched to n

[dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-11 Thread Andrew Rybchenko
Hi all, I think that Rx/Tx offloads checks behaviour is inconsistent in next-net as of today. Consistency checks are removed from PMDs and substituted with error logs in ethdev. Basically application which is not switched to new offload API has no way to find out if, for example, Rx scatter