[dpdk-dev] New driver (large patch) question.

2016-03-03 Thread Stephen Hurd
Unfortunately no. On Wed, Mar 2, 2016 at 9:53 PM, Qiu, Michael wrote: > On 3/3/2016 7:11 AM, Stephen Hurd wrote: > > On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon < > thomas.monjalon at 6wind.com> > > wrote: > > > >>> The comments in it are the only publicly available > >>> documentation on th

[dpdk-dev] New driver (large patch) question.

2016-03-03 Thread Qiu, Michael
On 3/3/2016 7:11 AM, Stephen Hurd wrote: > On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon > wrote: > >>> The comments in it are the only publicly available >>> documentation on the hardware I'm aware of. >> So you must keep the comments. >> > That's my goal, but the comments are well over the 300

[dpdk-dev] New driver (large patch) question.

2016-03-03 Thread Thomas Monjalon
2016-03-02 15:10, Stephen Hurd: > On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon > wrote: > > > The driver itself doesn't have a lot of optional features in it, it's the > > > header file that's too big. > > > > It is big because there are many different things. > > You can split the file in diff

[dpdk-dev] New driver (large patch) question.

2016-03-03 Thread Vincent JARDIN
Please, Le 02/03/2016 22:30, Stephen Hurd a ?crit : > Too many of the DPDK drivers are bloated. >>Recall the venerable paraphrase of Pascal, "I made this so long because I >>did not have time to make it shorter." >>https://en.wikipedia.org/wiki/Wikipedia:Too_long;_didn%27t_read Keep In Simple, Sm

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Bruce Richardson
On Thu, Mar 03, 2016 at 12:07:21AM +0100, Vincent JARDIN wrote: > Please, > > Le 02/03/2016 22:30, Stephen Hurd a ?crit : > >Too many of the DPDK drivers are bloated. > >>Recall the venerable paraphrase of Pascal, "I made this so long because I > >>did not have time to make it shorter." > >>https:

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Thomas Monjalon
2016-03-02 14:06, Stephen Hurd: > The issue is that the big header in question is the whole hardware/firmware > interface definition. The comments in it are the only publicly available > documentation on the hardware I'm aware of. So you must keep the comments. > The driver itself doesn't have a

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Thomas Monjalon
2016-03-02 13:30, Stephen Hurd: > The bulk of the patch is the hardware interface header file. With all the > comments, it weighs in around 800k. If I strip the comments, it's around > 300k. If I both strip all the comments and remove all the currently unused > structures, I can get the entire p

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Wiles, Keith
>The issue is that the big header in question is the whole hardware/firmware >interface definition. The comments in it are the only publicly available >documentation on the hardware I'm aware of. > >The driver itself doesn't have a lot of optional features in it, it's the >header file that's too b

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
On Wed, Mar 2, 2016 at 4:29 PM, Thomas Monjalon wrote: > > Should I split additional definitions/documentation that's not currently > > used in the driver as well? Or should it stay as only enough to document > > what the driver already does? > > I don't understand the question. > If something i

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon wrote: > > The comments in it are the only publicly available > > documentation on the hardware I'm aware of. > > So you must keep the comments. > That's my goal, but the comments are well over the 300k limit. > > The driver itself doesn't have a

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
The issue is that the big header in question is the whole hardware/firmware interface definition. The comments in it are the only publicly available documentation on the hardware I'm aware of. The driver itself doesn't have a lot of optional features in it, it's the header file that's too big. O

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
The bulk of the patch is the hardware interface header file. With all the comments, it weighs in around 800k. If I strip the comments, it's around 300k. If I both strip all the comments and remove all the currently unused structures, I can get the entire patch down just below 300k, but that make

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Thomas Monjalon
Hi, 2016-03-01 19:56, Stephen Hurd: > I submitted a new driver on Friday, and it was rejected for being over 300k. > > The rejection email suggested contacing dev-owner at dpdk.org, which I did on > Monday with no reply. > > What's the process to submit patches larger than the mailing list size

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hemminger
On Wed, 02 Mar 2016 11:21:26 +0100 Thomas Monjalon wrote: > Hi, > > 2016-03-01 19:56, Stephen Hurd: > > I submitted a new driver on Friday, and it was rejected for being over 300k. > > > > The rejection email suggested contacing dev-owner at dpdk.org, which I did > > on > > Monday with no repl

[dpdk-dev] New driver (large patch) question.

2016-03-01 Thread Stephen Hurd
I submitted a new driver on Friday, and it was rejected for being over 300k. The rejection email suggested contacing dev-owner at dpdk.org, which I did on Monday with no reply. What's the process to submit patches larger than the mailing list size limit? -- Stephen Hurd Principal Engineer - Sof