Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-04-03 Thread Wiles, Keith
> On Apr 3, 2018, at 5:41 AM, Neil Horman wrote: > > On Mon, Apr 02, 2018 at 09:25:15AM -0700, Stephen Hemminger wrote: >> On Sat, 31 Mar 2018 14:48:55 -0400 >> Neil Horman wrote: >> >>> On Sat, Mar 31, 2018 at 06:21:41PM +0200, Gaëtan Rivet wrote: On Sat, Mar 31, 2018 at 11:27:55AM -040

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-04-03 Thread Neil Horman
On Mon, Apr 02, 2018 at 09:25:15AM -0700, Stephen Hemminger wrote: > On Sat, 31 Mar 2018 14:48:55 -0400 > Neil Horman wrote: > > > On Sat, Mar 31, 2018 at 06:21:41PM +0200, Gaëtan Rivet wrote: > > > On Sat, Mar 31, 2018 at 11:27:55AM -0400, Neil Horman wrote: > > > > On Sat, Mar 31, 2018 at 05:

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-04-03 Thread Thomas Monjalon
03/04/2018 10:31, Maxime Coquelin: > On 04/02/2018 06:25 PM, Stephen Hemminger wrote: > > Rather than wallpapering over the unused result, why not do real error > > checking? > > If the program was run in a non-Linux environment (such as WSL etc), maybe > > an error > > could occur. Best to retur

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-04-03 Thread Maxime Coquelin
On 04/02/2018 06:25 PM, Stephen Hemminger wrote: On Sat, 31 Mar 2018 14:48:55 -0400 Neil Horman wrote: On Sat, Mar 31, 2018 at 06:21:41PM +0200, Gaëtan Rivet wrote: On Sat, Mar 31, 2018 at 11:27:55AM -0400, Neil Horman wrote: On Sat, Mar 31, 2018 at 05:09:47PM +0200, Gaëtan Rivet wrote: O

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-04-02 Thread Stephen Hemminger
On Sat, 31 Mar 2018 14:48:55 -0400 Neil Horman wrote: > On Sat, Mar 31, 2018 at 06:21:41PM +0200, Gaëtan Rivet wrote: > > On Sat, Mar 31, 2018 at 11:27:55AM -0400, Neil Horman wrote: > > > On Sat, Mar 31, 2018 at 05:09:47PM +0200, Gaëtan Rivet wrote: > > > > On Sat, Mar 31, 2018 at 09:33:43AM

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-31 Thread Neil Horman
On Sat, Mar 31, 2018 at 06:21:41PM +0200, Gaëtan Rivet wrote: > On Sat, Mar 31, 2018 at 11:27:55AM -0400, Neil Horman wrote: > > On Sat, Mar 31, 2018 at 05:09:47PM +0200, Gaëtan Rivet wrote: > > > On Sat, Mar 31, 2018 at 09:33:43AM -0400, Neil Horman wrote: > > > > On Fri, Mar 30, 2018 at 10:47:09P

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-31 Thread Gaëtan Rivet
On Sat, Mar 31, 2018 at 11:27:55AM -0400, Neil Horman wrote: > On Sat, Mar 31, 2018 at 05:09:47PM +0200, Gaëtan Rivet wrote: > > On Sat, Mar 31, 2018 at 09:33:43AM -0400, Neil Horman wrote: > > > On Fri, Mar 30, 2018 at 10:47:09PM +0800, Tonghao Zhang wrote: > > > > I rebuild it on ubuntu 17.10 and

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-31 Thread Neil Horman
On Sat, Mar 31, 2018 at 05:09:47PM +0200, Gaëtan Rivet wrote: > On Sat, Mar 31, 2018 at 09:33:43AM -0400, Neil Horman wrote: > > On Fri, Mar 30, 2018 at 10:47:09PM +0800, Tonghao Zhang wrote: > > > I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix > > > it. > > > > > > >

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-31 Thread Gaëtan Rivet
On Sat, Mar 31, 2018 at 09:33:43AM -0400, Neil Horman wrote: > On Fri, Mar 30, 2018 at 10:47:09PM +0800, Tonghao Zhang wrote: > > I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix > > it. > > > > > > diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c > > i

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-31 Thread Neil Horman
On Fri, Mar 30, 2018 at 10:47:09PM +0800, Tonghao Zhang wrote: > I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix it. > > > diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c > index 771675718..f11803191 100644 > --- a/lib/librte_vhost/fd_man.c > +++ b/lib

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
On Fri, Mar 30, 2018 at 10:59 PM, Maxime Coquelin wrote: > Thanks Xiangxia, > > I can post it, do you agree if I add below comments? yes, thanks. > On 03/30/2018 04:47 PM, Tonghao Zhang wrote: >> >> I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix >> it. >> >> >> diff --g

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
Thanks Xiangxia, I can post it, do you agree if I add below comments? On 03/30/2018 04:47 PM, Tonghao Zhang wrote: I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix it. diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c index 771675718..f11803191 100644

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 04:28 PM, Timothy Redaelli wrote: On Fri, 30 Mar 2018 15:27:55 +0200 Maxime Coquelin wrote: Hi Andrew, On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix it. diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c index 771675718..f11803191 100644 --- a/lib/librte_vhost/fd_man.c +++ b/lib/librte_vhost/fd_man.c @@ -279,7 +279,8 @@ fdset_pipe_read_cb(int readfd, voi

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Timothy Redaelli
On Fri, 30 Mar 2018 15:27:55 +0200 Maxime Coquelin wrote: > Hi Andrew, > > On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: > > Hi all, > > > > Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: > > > > lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: > > lib/librte_vhost/fd

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 04:16 PM, Tonghao Zhang wrote: On Fri, Mar 30, 2018 at 10:13 PM, Ferruh Yigit wrote: On 3/30/2018 2:27 PM, Maxime Coquelin wrote: Hi Andrew, On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/f

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
On Fri, Mar 30, 2018 at 10:13 PM, Ferruh Yigit wrote: > On 3/30/2018 2:27 PM, Maxime Coquelin wrote: >> Hi Andrew, >> >> On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: >>> Hi all, >>> >>> Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: >>> >>> lib/librte_vhost/fd_man.c: In function ‘fd

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Ferruh Yigit
On 3/30/2018 2:27 PM, Maxime Coquelin wrote: > Hi Andrew, > > On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: >> Hi all, >> >> Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: >> >> lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: >> lib/librte_vhost/fd_man.c:284:2: error: ig

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
Hi Andrew, On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unus

[dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Andrew Rybchenko
Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Werror=unused-result] read(readfd, charbuf, siz