[dpdk-dev] Bugs in newest patches

2014-11-07 Thread Keunhong Lee
I did not included the generic header directly. I thought that this nested "extern C" is intended, however, according to your reply, this might be removed at all. There is a remaining """ #ifdef _cplusplus } #endif """ at the end of "generic/rte_cycles.h". I think this should be removed. This caus

[dpdk-dev] Bugs in newest patches

2014-11-07 Thread David Marchand
Hello, On Fri, Nov 7, 2014 at 2:26 AM, Keunhong Lee wrote: > I did not included the generic header directly. > I thought that this nested "extern C" is intended, > however, according to your reply, this might be removed at all. > > There is a remaining > """ > #ifdef _cplusplus > } > #endif > ""

[dpdk-dev] Bugs in newest patches

2014-11-07 Thread Keunhong Lee
Hi. I just pulled new patches from the master branch, and found that it doesn't work with C++. in lib/librte_eal/common/include/generic/rte_cycles.h missing opening extern "C" in commit fa4001c30ee9d9ecfb3ca5d93d68ef0394e9950a here is the fix. - * Simple Time Reference Functions (Cycles

[dpdk-dev] Bugs in newest patches

2014-11-06 Thread Thomas Monjalon
Hi, 2014-11-07 05:21, Keunhong Lee: > I just pulled new patches from the master branch, and found that it doesn't > work with C++. > > in lib/librte_eal/common/include/generic/rte_cycles.h > +#ifdef __cplusplus > +extern "C" { > +#endif It's already included in lib/librte_eal/common/include/arc