Re: [dpdk-dev] Admin Queue ENA

2019-12-16 Thread Michał Krawczyk
Hi Param, Those fields are no longer existing in the newer version of the ena_com (and newer DPDK), so please upgrade if you are encountering any issues. But I don't think that TSO is supported on any of the ENA devices on the AWS. Thanks, Michal niedz., 8 gru 2019 o 20:03 kumaraparameshwaran ra

Re: [dpdk-dev] Admin Queue ENA

2019-12-08 Thread kumaraparameshwaran rathinavel
Thanks a lot Michal. Will follow approach that you have suggested. Also I see that in case if TSO is enabled we set, 336 /* this param needed only for TSO */ 337 ena_meta->l3_outer_hdr_len = 0; 338 ena_meta->l3_outer_hdr_offset = 0; So even if TSO is enabled shoul

Re: [dpdk-dev] Admin Queue ENA

2019-12-04 Thread Michał Krawczyk
Hi Param, Adding atomic operations to setting/clearing comp ctxt won't help, as there is no race there. The admin queue is designed this way, that only single completion context can be held, so you should serialize access to the rte_eth_stats_get(). If you won't do that, the 2nd thread will try to

Re: [dpdk-dev] Admin Queue ENA

2019-11-29 Thread kumaraparameshwaran rathinavel
Hi Michał, Thanks for getting back on this. In our design we are using multiple cores requesting for rte_eth_stats_get, it is not from one process and hence not serialized. Since in our design this is not serialized, and hence in get_comp_ctxt() checking for occupied flag and comp_ctxt_release()

Re: [dpdk-dev] Admin Queue ENA

2019-11-28 Thread Michał Krawczyk
Hi Param, first of all - you are using very old ena_com. This code comes from the DPDK version before v18.08. If you have any doubts, please check the newer version of the driver and DPDK as the potential bug could be already fixed there. Anyway, if you will look at the function get_comp_ctxt() w

Re: [dpdk-dev] Admin Queue ENA

2019-11-07 Thread kumaraparameshwaran rathinavel
Hi Michał, Please look at the below function, static int ena_com_wait_and_process_admin_cq_polling( struct ena_comp_ctx *comp_ctx, struct ena_com_admin_queue *admin_queue) { unsigned long flags = 0; u64 start_time; int ret; start_time = ENA_GET_SYSTEM_USECS();

Re: [dpdk-dev] Admin Queue ENA

2019-10-24 Thread Michał Krawczyk
sob., 19 paź 2019 o 20:26 kumaraparameshwaran rathinavel napisał(a): > > Hi All, > > In the ENA poll mode driver I see that every request in the admin queue is > associated with a completion context and this is preallocated during the > device initialisation. When the completion context is used we

[dpdk-dev] Admin Queue ENA

2019-10-19 Thread kumaraparameshwaran rathinavel
Hi All, In the ENA poll mode driver I see that every request in the admin queue is associated with a completion context and this is preallocated during the device initialisation. When the completion context is used we check for occupied to be true in the 16.X version if the occupied flag is set to