[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

Hi, Slava > -邮件原件- > 发件人: Slava Ovsiienko > 发送时间: 2021年5月13日 18:49 > 收件人: Feifei Wang ; Matan Azrad > ; Shahaf Shuler > 抄送: dev@dpdk.org; nd ; sta...@dpdk.org; Ruifeng Wang > ; nd ; nd > 主题: RE: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache > > Hi, Feifei > > .. sni

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

Hi, Slava Please see below. > -邮件原件- > 发件人: Slava Ovsiienko > 发送时间: 2021年5月12日 19:08 > 收件人: Feifei Wang ; Matan Azrad > ; Shahaf Shuler > 抄送: dev@dpdk.org; nd ; sta...@dpdk.org; Ruifeng Wang > ; nd > 主题: RE: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache > > Hi, Feif

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

Hi, Slava Please see below. > -邮件原件- > 发件人: Slava Ovsiienko > 发送时间: 2021年5月11日 16:19 > 收件人: Feifei Wang ; Matan Azrad > ; Shahaf Shuler > 抄送: dev@dpdk.org; nd ; sta...@dpdk.org; Ruifeng Wang > ; nd ; nd > 主题: RE: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache > > Hi,

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

Hi, Slava Thanks for your explanation. Thus we can ignore the order between update global cache and update dev_gen due to R/W lock. Furthermore, it is unnecessary to keep wmb, and the last wmb (1d) I think can be removed. Two reasons for this: 1. wmb has only one function, this is for the loca

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

Hi, Slava Thanks very much for your reply. > -邮件原件- > 发件人: Slava Ovsiienko > 发送时间: 2021年5月6日 19:22 > 收件人: Feifei Wang ; Matan Azrad > ; Shahaf Shuler > 抄送: dev@dpdk.org; nd ; sta...@dpdk.org; Ruifeng Wang > ; nd > 主题: RE: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

Hi, Slava Would you have more comments about this patch? For my sight, only one wmb before "dev_gen" updating is enough to synchronize. Thanks very much for your attention. Best Regards Feifei > -邮件原件- > 发件人: Feifei Wang > 发送时间: 2021年4月20日 16:42 > 收件人: Slava Ovsiienko ; Matan Azrad >

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

Hi, Slava I think the second wmb can be removed. As I know, wmb is just a barrier to keep the order between write and write. and it cannot tell the CPU when it should commit the changes. It is usually used before guard variable to keep the order that updating guard variable after some changes,

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

Hi, Slava Another question suddenly occurred to me, in order to keep the order that rebuilding global cache before updating ”dev_gen“, the wmb should be before updating "dev_gen" rather than after it. Otherwise, in the out-of-order platforms, current order cannot be kept. Thus, we should change

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

Hi, Slava Thanks very much for your explanation. I can understand the app can wait all mbufs are returned to the memory pool, and then it can free this mbufs, I agree with this. As a result, I will remove the bug fix patch from this series and just replace the smp barrier with C11 thread fence.

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

Hi, Slava Thanks very much for your attention. Best Regards Feifei > -邮件原件- > 发件人: Slava Ovsiienko > 发送时间: 2021年4月12日 16:28 > 收件人: Feifei Wang ; Matan Azrad > ; Shahaf Shuler ; > ys...@mellanox.com > 抄送: dev@dpdk.org; nd ; sta...@dpdk.org; Ruifeng Wang > > 主题: RE: [PATCH v1 3/4] ne