Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-28 Thread Ananyev, Konstantin
Hi Akhil, > Hi Konstantin, > > > > > Hi Tech board members, > > > > > > > > I have a doubt about the ABI breakage in below addition of field. > > > > Could you please comment. > > > > > > > > > /** The data structure associated with each crypto device. */ struct > > > > > rte_cryptodev { > >

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-28 Thread Akhil Goyal
Hi Konstantin, > > > Hi Tech board members, > > > > > > I have a doubt about the ABI breakage in below addition of field. > > > Could you please comment. > > > > > > > /** The data structure associated with each crypto device. */ struct > > > > rte_cryptodev { > > > > dequeue_pkt_burst

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-28 Thread Ananyev, Konstantin
> > Hi Tech board members, > > Could you please clarify the concern? > The latest patch (https://patches.dpdk.org/patch/82536/) supports both > enqueue and dequeue callback functionality. > > Thanks > Abhinandan > > > -Original Message- > > From: Akhil Goyal > > Sent: Tuesday, Octob

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-28 Thread Gujjar, Abhinandan S
Hi Tech board members, Could you please clarify the concern? The latest patch (https://patches.dpdk.org/patch/82536/) supports both enqueue and dequeue callback functionality. Thanks Abhinandan > -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 27, 2020 11:59 PM > To: Gu

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-27 Thread Gujjar, Abhinandan S
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Wednesday, October 28, 2020 12:56 AM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; > honnappa.nagaraha...@arm.com; Ananyev, Konstantin > > Cc: Vangati, Narender ; jer...@marvell.com > Subject: RE: [v4 1/3] crypto

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-27 Thread Akhil Goyal
Hi Abhinandan, > > > +static int > > > +cryptodev_cb_init(struct rte_cryptodev *dev) { > > > + struct rte_cryptodev_enq_cb_rcu *list; > > > + struct rte_rcu_qsbr *qsbr; > > > + uint16_t qp_id; > > > + size_t size; > > > + > > > + /* Max thread set to 1, as one DP thread accessing a queue-pair */ >

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-27 Thread Gujjar, Abhinandan S
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 27, 2020 11:49 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; > honnappa.nagaraha...@arm.com; Ananyev, Konstantin > > Cc: Vangati, Narender ; jer...@marvell.com > Subject: RE: [v4 1/3] cryptodev: suppo

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-27 Thread Akhil Goyal
Hi Tech board members, I have a doubt about the ABI breakage in below addition of field. Could you please comment. > /** The data structure associated with each crypto device. */ > struct rte_cryptodev { > dequeue_pkt_burst_t dequeue_burst; > @@ -867,6 +922,10 @@ struct rte_cryptodev { >

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-27 Thread Akhil Goyal
Hi Abhinandan, > Subject: [v4 1/3] cryptodev: support enqueue callback functions > > This patch adds APIs to add/remove callback functions. The callback > function will be called for each burst of crypto ops received on a > given crypto device queue pair. > > Signed-off-by: Abhinandan Gujjar > -

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-27 Thread Gujjar, Abhinandan S
Sure Konstantin. Thanks Abhinandan > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, October 27, 2020 10:51 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; akhil.go...@nxp.com; > honnappa.nagaraha...@arm.com > Cc: Vangati, Narender ; jer...@marvell.com >

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-27 Thread Ananyev, Konstantin
> > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Tuesday, October 27, 2020 6:18 PM > > To: Gujjar, Abhinandan S ; dev@dpdk.org; > > Doherty, Declan ; akhil.go...@nxp.com; > > honnappa.nagaraha...@arm.com > > Cc: Vangati, Narender ; jer...@marvell.com > > Subject: RE: [v4 1

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-27 Thread Gujjar, Abhinandan S
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, October 27, 2020 6:18 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; akhil.go...@nxp.com; > honnappa.nagaraha...@arm.com > Cc: Vangati, Narender ; jer...@marvell.com > Subject: RE: [v4 1/3] cryptodev: s

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-27 Thread Ananyev, Konstantin
> > This patch adds APIs to add/remove callback functions. The callback > function will be called for each burst of crypto ops received on a > given crypto device queue pair. > > Signed-off-by: Abhinandan Gujjar > --- > config/rte_config.h| 1 + > lib/librte_cryp

[dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-26 Thread Abhinandan Gujjar
This patch adds APIs to add/remove callback functions. The callback function will be called for each burst of crypto ops received on a given crypto device queue pair. Signed-off-by: Abhinandan Gujjar --- config/rte_config.h| 1 + lib/librte_cryptodev/meson.build