[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-02 Thread Hiroshi Shimamoto
> Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > recv/xmit > > On Wed, Oct 01, 2014 at 11:33:23PM +, Hiroshi Shimamoto wrote: > > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > > > recv/xmit > > > &

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-01 Thread Hiroshi Shimamoto
> Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > recv/xmit > > On Wed, Oct 01, 2014 at 09:12:44AM +, Hiroshi Shimamoto wrote: > > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > > > recv/xmit > > > &

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-01 Thread Neil Horman
On Thu, Oct 02, 2014 at 02:07:09AM +, Hiroshi Shimamoto wrote: > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > > recv/xmit > > > > On Wed, Oct 01, 2014 at 11:33:23PM +, Hiroshi Shimamoto wrote: > > > > Subject: Re: [dpdk

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-01 Thread Neil Horman
On Wed, Oct 01, 2014 at 11:33:23PM +, Hiroshi Shimamoto wrote: > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > > recv/xmit > > > > On Wed, Oct 01, 2014 at 09:12:44AM +, Hiroshi Shimamoto wrote: > > > > Subject: Re: [dpdk

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-01 Thread Bruce Richardson
On Tue, Sep 30, 2014 at 11:52:00PM +, Hiroshi Shimamoto wrote: > Hi, > > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > > recv/xmit > > > > On Tue, Sep 30, 2014 at 11:14:40AM +, Hiroshi Shimamoto wrote: > > > From: H

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-01 Thread Hiroshi Shimamoto
> Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > recv/xmit > > On Tue, Sep 30, 2014 at 11:52:00PM +, Hiroshi Shimamoto wrote: > > Hi, > > > > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > > > rec

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-01 Thread Thomas Monjalon
2014-10-01 00:01, Hiroshi Shimamoto: > > The patch is ok. For the commit message, is it better > > "to reduce branch mispredication"? > > yes, that seems more suitable to explain the situation. > > Thomas, what do you think? Can you replace the message when you apply > this patch? Yes, I did it

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-01 Thread Neil Horman
On Wed, Oct 01, 2014 at 09:12:44AM +, Hiroshi Shimamoto wrote: > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > > recv/xmit > > > > On Tue, Sep 30, 2014 at 11:52:00PM +, Hiroshi Shimamoto wrote: > > > Hi, > > > > >

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-01 Thread Neil Horman
On Wed, Oct 01, 2014 at 09:44:45AM +0100, Bruce Richardson wrote: > On Tue, Sep 30, 2014 at 11:52:00PM +, Hiroshi Shimamoto wrote: > > Hi, > > > > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > > > recv/xmit > > > >

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-01 Thread Hiroshi Shimamoto
e the message when you apply this patch? thanks, Hiroshi > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Hiroshi Shimamoto > > Sent: Tuesday, September 30, 2014 7:15 PM > > To: dev at dpdk.org > > Cc: Hayato Momma > &

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-09-30 Thread Hiroshi Shimamoto
Hi, > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > recv/xmit > > On Tue, Sep 30, 2014 at 11:14:40AM +, Hiroshi Shimamoto wrote: > > From: Hiroshi Shimamoto > > > > To reduce instruction cache miss, add branch condition hints into

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-09-30 Thread Thomas Monjalon
2014-09-30 14:38, Xie, Huawei: > > - if (++next >= MEMNIC_NR_PACKET) > > + if (unlikely(++next >= MEMNIC_NR_PACKET)) > > On IA, compiler can use add, cmp and cmov to avoid branch. > But If MEMNIC_NR_PACKET is always power of 2, > it is better just next = (next + 1) & (M

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-09-30 Thread Xie, Huawei
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Hiroshi Shimamoto > Sent: Tuesday, September 30, 2014 7:15 PM > To: dev at dpdk.org > Cc: Hayato Momma > Subject: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit > >

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-09-30 Thread Xie, Huawei
to Momma > Subject: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit > > From: Hiroshi Shimamoto > > To reduce instruction cache miss, add branch condition hints into > recv/xmit functions. This improves a bit performance. > > We can see performance impr

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-09-30 Thread Hiroshi Shimamoto
From: Hiroshi Shimamoto To reduce instruction cache miss, add branch condition hints into recv/xmit functions. This improves a bit performance. We can see performance improvements with memnic-tester. Using Xeon E5-2697 v2 @ 2.70GHz, 4 vCPU. size | before | after 64 | 5.54Mpps | 5.55Mpps

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-09-30 Thread Neil Horman
On Tue, Sep 30, 2014 at 11:14:40AM +, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > To reduce instruction cache miss, add branch condition hints into > recv/xmit functions. This improves a bit performance. > > We can see performance improvements with memnic-tester. > Using Xeon E5-2