[dpdk-dev] [dpdk-dev, 2/2] ethdev: move code to common place in hotplug

2016-01-22 Thread David Marchand
Hello, On Thu, Jan 21, 2016 at 7:42 PM, Thomas Monjalon wrote: > 2016-01-21 19:06, David Marchand: >> On Thu, Jan 21, 2016 at 4:38 PM, Jan Viktorin >> wrote: >> > This change modifies the return value from -EINVAL to -1. I don't know >> > whether is this an issue but it looks suspicious. >> >>

[dpdk-dev] [dpdk-dev, 2/2] ethdev: move code to common place in hotplug

2016-01-21 Thread Thomas Monjalon
2016-01-21 19:06, David Marchand: > On Thu, Jan 21, 2016 at 4:38 PM, Jan Viktorin > wrote: > > On Thu, 21 Jan 2016 12:57:11 +0100 > > David Marchand wrote: > > > [snip] > >> @@ -612,14 +599,25 @@ int > >> rte_eth_dev_attach(const char *devargs, uint8_t *port_id) > >> { > >> struct rte_pc

[dpdk-dev] [dpdk-dev, 2/2] ethdev: move code to common place in hotplug

2016-01-21 Thread David Marchand
On Thu, Jan 21, 2016 at 4:38 PM, Jan Viktorin wrote: > On Thu, 21 Jan 2016 12:57:11 +0100 > David Marchand wrote: > [snip] >> @@ -612,14 +599,25 @@ int >> rte_eth_dev_attach(const char *devargs, uint8_t *port_id) >> { >> struct rte_pci_addr addr; >> + int ret = -1; >> >> if ((d

[dpdk-dev] [dpdk-dev, 2/2] ethdev: move code to common place in hotplug

2016-01-21 Thread Jan Viktorin
On Thu, 21 Jan 2016 12:57:11 +0100 David Marchand wrote: > Move these error logs and checks on detach capabilities in a common place. > > Signed-off-by: David Marchand > > --- > lib/librte_ether/rte_ethdev.c | 69 +-- > 1 file changed, 40 insertions(+),