Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-14 Thread Jerin Jacob
gt;> Sent: Friday, September 6, 2019 4:38 PM > >>>> To: Zapolski, MarcinX A ; dev@dpdk.org > >>>> Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev > >>>> structures from public API > >>>> > >>>> On 9/6/

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-10 Thread Zapolski, MarcinX A
> -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, September 10, 2019 2:20 PM > To: Zapolski, MarcinX A > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev > structures from public AP

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-10 Thread Bruce Richardson
; Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev > > structures from public API > > > > On Tue, Sep 10, 2019 at 09:59:51AM +, Zapolski, MarcinX A wrote: > > > <...> > > > > @@ -3994,7 +4054,55 @@ void * > > > >

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-10 Thread Zapolski, MarcinX A
> -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, September 10, 2019 12:07 PM > To: Zapolski, MarcinX A > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev > structures from public AP

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-10 Thread Bruce Richardson
On Tue, Sep 10, 2019 at 09:59:51AM +, Zapolski, MarcinX A wrote: > <...> > > @@ -3994,7 +4054,55 @@ void * > > rte_eth_dev_get_sec_ctx(uint16_t port_id); > > > > > > -#include > > +struct rte_eth_dev_callback; > > +/** Structure to keep track of registered callbacks */ > > +TAILQ_HEAD(rte_e

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-10 Thread Zapolski, MarcinX A
<...> > @@ -3994,7 +4054,55 @@ void * > rte_eth_dev_get_sec_ctx(uint16_t port_id); > > > -#include > +struct rte_eth_dev_callback; > +/** Structure to keep track of registered callbacks */ > +TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback); > + > +/** > + * Structure used to hold informat

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-09 Thread Zapolski, MarcinX A
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, September 9, 2019 12:24 PM > To: Zapolski, MarcinX A ; dev@dpdk.org > Cc: Jerin Jacob ; Laatz, Kevin > > Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev > structures from public API &

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-09 Thread Ferruh Yigit
On 9/9/2019 11:02 AM, Zapolski, MarcinX A wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Monday, September 9, 2019 12:00 PM >> To: Zapolski, MarcinX A ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev >> s

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-09 Thread Zapolski, MarcinX A
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, September 9, 2019 12:00 PM > To: Zapolski, MarcinX A ; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev > structures from public API > > On 9/9/2019 9:07 AM, Z

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-09 Thread Ferruh Yigit
On 9/9/2019 9:07 AM, Zapolski, MarcinX A wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, September 6, 2019 4:38 PM >> To: Zapolski, MarcinX A ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev >> str

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-09 Thread Zapolski, MarcinX A
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, September 6, 2019 7:24 PM > To: Zapolski, MarcinX A > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev > structures from public AP

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-09 Thread Zapolski, MarcinX A
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, September 6, 2019 4:38 PM > To: Zapolski, MarcinX A ; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev > structures from public API > > On 9/6/2019 2:18 PM, Marcin Z

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-06 Thread Stephen Hemminger
On Fri, 6 Sep 2019 15:18:11 +0200 Marcin Zapolski wrote: > +RTE_INIT(rte_eth_dev_init) > +{ > + int i; > + > + for (i = 0; i < RTE_MAX_ETHPORTS; i++) > + rte_eth_dev_functions[i] = > + (struct rte_eth_dev_fcns *)(&rte_eth_devices[i]); Casts are error pron

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-06 Thread Ferruh Yigit
On 9/6/2019 2:18 PM, Marcin Zapolski wrote: > Split rte_eth_dev structure to two parts: head that is available for > user applications, and rest which is DPDK internal. > Make an array of pointers to rte_eth_dev structures available for user > applications. > > Signed-off-by: Marcin Zapolski <..

[dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-06 Thread Marcin Zapolski
Split rte_eth_dev structure to two parts: head that is available for user applications, and rest which is DPDK internal. Make an array of pointers to rte_eth_dev structures available for user applications. Signed-off-by: Marcin Zapolski --- lib/librte_bitratestats/rte_bitrate.c | 2 +-