Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-03-05 Thread Ravi Kerur
Hi Konstantin, Thanks for the inputs. Initialization starts with ETH_RSS_IP and gets updated with L4 if ACL is selected in parse_args function. This change is to fix rss_hf. I have submitted 'v4' patch, please let me know if additional changes are needed. Thanks. On Sun, Mar 5, 2017 at 5:15 AM

Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-03-05 Thread Ananyev, Konstantin
Hi Ravi, > > Hi Konstantin, > > Sorry for this one, I had to resend patch series as 'v3' as additional > checkpatch warnings were seen after the submission which didn't show > up in my run. > > 'v3' patch should have all fixed except the ones I mentioned in my earlier > email on which I need

Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-03-04 Thread Ravi Kerur
Hi Konstantin, Sorry for this one, I had to resend patch series as 'v3' as additional checkpatch warnings were seen after the submission which didn't show up in my run. 'v3' patch should have all fixed except the ones I mentioned in my earlier email on which I need inputs from you. Thanks. On S

Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-03-04 Thread Ravi Kerur
Hi Konstantin, I have sent 'v2' patchset. I need clarifications on following things, if they should be fixed I will send out 'v3' so please let me know. Following code changes were done by me manually, not merged. +++ b/examples/l3fwd/main.c @@ -161,7 +163,9 @@ static struct rte_eth_conf port_co

Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-03-01 Thread Ravi Kerur
Hi Konstantin, Thank you for the review. RSS hash value changes could be due to merge, I didn't make that change. I will go through the changes and fix it in 'v2' patch along with RFC removed and checkpatch fix. Thanks. On Tue, Feb 28, 2017 at 2:36 AM, Ananyev, Konstantin < konstantin.anan...@i

Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-02-28 Thread Ananyev, Konstantin
Hi Ravi, > > Thanks to Konstantin and Bruce on first internal review comments. This > patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file > read options to build LPM and EM tables. Thanks for the patch, I think it is really useful one. Can I suggest you re-submit it as non-RFC

[dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-01-27 Thread Ravi Kerur
Thanks to Konstantin and Bruce on first internal review comments. This patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file read options to build LPM and EM tables. Ravi Kerur (3): Merge l3fwd-acl and l3fwd LPM config file read option EM config file read option examples/l3