Re: [dpdk-dev] [RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code

2018-03-09 Thread Xu, Rosen
Thanks a lot Rivet, I have modified it, pls see my newest patch. -Original Message- From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] Sent: Tuesday, March 06, 2018 18:06 To: Xu, Rosen Cc: dev@dpdk.org; Doherty, Declan ; Zhang, Tianfei Subject: Re: [dpdk-dev] [RFC 1/4] drivers/bus

Re: [dpdk-dev] [RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code

2018-03-06 Thread Gaëtan Rivet
Hi Rosen, A few comments inline. (I will skip elements already pointed out by Shreyansh.) On Tue, Mar 06, 2018 at 09:43:55AM +0800, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > drivers/bus/ifpga/Makefile | 64 > drivers/bus/ifpga/ifpga_bus.c | 527 > ++

Re: [dpdk-dev] [RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code

2018-03-06 Thread Xu, Rosen
-Original Message- From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] Sent: Tuesday, March 06, 2018 14:10 To: Xu, Rosen Cc: dev@dpdk.org; Doherty, Declan ; Zhang, Tianfei Subject: Re: [dpdk-dev] [RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code Hello Rosen, I have some initial

Re: [dpdk-dev] [RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code

2018-03-05 Thread Shreyansh Jain
Hello Rosen, I have some initial (and most of them trivial) comments inline... On Tue, Mar 6, 2018 at 7:13 AM, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > drivers/bus/ifpga/Makefile | 64 > drivers/bus/ifpga/ifpga_bus.c | 527 > ++

[dpdk-dev] [RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code

2018-03-05 Thread Rosen Xu
Signed-off-by: Rosen Xu --- drivers/bus/ifpga/Makefile | 64 drivers/bus/ifpga/ifpga_bus.c | 527 drivers/bus/ifpga/ifpga_common.c| 168 + drivers/bus/ifpga/ifpga_common.h| 46 +++ drivers/bus/ifpga