Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set ops

2018-05-22 Thread Thomas Monjalon
25/01/2018 03:46, Wenzhuo Lu: > Setting the default MAC address may fail on many NICs. > But the ops return void. So, even it failed, RTE changes > the MAC address and APP doesn't know the failure. > > It's not real patch, just show the idea to add a return > value for the ops. > > BTW, > Seems w

Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set ops

2018-01-29 Thread Olivier Matz
y, January 25, 2018 6:40 PM > >> To: Lu, Wenzhuo > >> Cc: dev@dpdk.org > >> Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC > >> set > >> ops > >> > >> Hi Wenzhuo, > >> > >> On Thu, Jan 25, 2018

Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set ops

2018-01-26 Thread Ferruh Yigit
On 1/26/2018 2:19 AM, Lu, Wenzhuo wrote: > Hi Olivier, > > >> -Original Message- >> From: Olivier Matz [mailto:olivier.m...@6wind.com] >> Sent: Thursday, January 25, 2018 6:40 PM >> To: Lu, Wenzhuo >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-de

Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set ops

2018-01-25 Thread Lu, Wenzhuo
Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Thursday, January 25, 2018 6:40 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set > ops > > H

Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set ops

2018-01-25 Thread Olivier Matz
Hi Wenzhuo, On Thu, Jan 25, 2018 at 10:46:57AM +0800, Wenzhuo Lu wrote: > Setting the default MAC address may fail on many NICs. > But the ops return void. So, even it failed, RTE changes > the MAC address and APP doesn't know the failure. > > It's not real patch, just show the idea to add a retu

[dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set ops

2018-01-24 Thread Wenzhuo Lu
Setting the default MAC address may fail on many NICs. But the ops return void. So, even it failed, RTE changes the MAC address and APP doesn't know the failure. It's not real patch, just show the idea to add a return value for the ops. BTW, Seems we should do the same thing for rte_eth_dev_mac_a