Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-10-09 Thread Thomas Monjalon
28/09/2018 14:46, Ferruh Yigit: > On 9/8/2018 12:39 AM, Thomas Monjalon wrote: > > After closing a port, it cannot be restarted. > > So there is no reason to not free all associated resources. > > > > The last step was done with rte_eth_dev_detach() which is deprecated. > > Instead of removing the

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-09-28 Thread Ferruh Yigit
On 9/8/2018 12:39 AM, Thomas Monjalon wrote: > After closing a port, it cannot be restarted. > So there is no reason to not free all associated resources. > > The last step was done with rte_eth_dev_detach() which is deprecated. > Instead of removing the associated rte_device, the driver should ch

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-09-12 Thread Andrew Rybchenko
On 09/12/2018 05:57 PM, Thomas Monjalon wrote: 10/09/2018 10:54, Andrew Rybchenko: On 09/10/2018 11:42 AM, Thomas Monjalon wrote: 10/09/2018 10:03, Andrew Rybchenko: On 09/08/2018 02:39 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-09-12 Thread Thomas Monjalon
10/09/2018 10:54, Andrew Rybchenko: > On 09/10/2018 11:42 AM, Thomas Monjalon wrote: > > 10/09/2018 10:03, Andrew Rybchenko: > >> On 09/08/2018 02:39 AM, Thomas Monjalon wrote: > >>> After closing a port, it cannot be restarted. > >>> So there is no reason to not free all associated resources. > >>

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-09-10 Thread Andrew Rybchenko
On 09/10/2018 11:42 AM, Thomas Monjalon wrote: 10/09/2018 10:03, Andrew Rybchenko: On 09/08/2018 02:39 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-09-10 Thread Thomas Monjalon
10/09/2018 10:03, Andrew Rybchenko: > On 09/08/2018 02:39 AM, Thomas Monjalon wrote: > > After closing a port, it cannot be restarted. > > So there is no reason to not free all associated resources. > > > > The last step was done with rte_eth_dev_detach() which is deprecated. > > Instead of removin

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-09-10 Thread Andrew Rybchenko
On 09/08/2018 02:39 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of removing the associated rte_device, the driver should check if

[dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-09-07 Thread Thomas Monjalon
After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of removing the associated rte_device, the driver should check if no more port (ethdev, cryptodev, etc) is still o