Re: [dpdk-dev] [RFC] add flow action context API

2020-06-09 Thread Jerin Jacob
On Thu, Jun 4, 2020 at 9:27 PM Andrey Vesnovaty wrote: > > On Thu, Jun 4, 2020 at 3:37 PM Jerin Jacob wrote: >> >> I would suggest adding rte_flow driver implementers if there is a >> change in rte_flow_ops in RFC so that >> your patch will get enough. I added the maintainers of rte_flow PMD[1] >

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-05 Thread Thomas Monjalon
05/06/2020 10:30, Bruce Richardson: > On Thu, Jun 04, 2020 at 07:23:04PM +0200, Thomas Monjalon wrote: > > 04/06/2020 13:12, Andrey Vesnovaty: > > > Thomas Monjalon wrote: > > > > 20/05/2020 11:18, Andrey Vesnovaty: > > > > We had "create", "destroy", "query", but no "modify" capability. > > > > T

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-05 Thread Bruce Richardson
On Thu, Jun 04, 2020 at 07:23:04PM +0200, Thomas Monjalon wrote: > 04/06/2020 13:12, Andrey Vesnovaty: > > Thomas Monjalon wrote: > > > 20/05/2020 11:18, Andrey Vesnovaty: > > > We had "create", "destroy", "query", but no "modify" capability. > > > The new API is adding 2 things in my opinion: > >

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-04 Thread Thomas Monjalon
04/06/2020 13:12, Andrey Vesnovaty: > Thomas Monjalon wrote: > > 20/05/2020 11:18, Andrey Vesnovaty: > > We had "create", "destroy", "query", but no "modify" capability. > > The new API is adding 2 things in my opinion: > > - shared action object > > - "modify" capability (is "upda

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-04 Thread Andrey Vesnovaty
On Thu, Jun 4, 2020 at 3:37 PM Jerin Jacob wrote: > I would suggest adding rte_flow driver implementers if there is a > change in rte_flow_ops in RFC so that > your patch will get enough. I added the maintainers of rte_flow PMD[1] > implementers in Cc. > > > >> > >> Would the following additional

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-04 Thread Jerin Jacob
I would suggest adding rte_flow driver implementers if there is a change in rte_flow_ops in RFC so that your patch will get enough. I added the maintainers of rte_flow PMD[1] implementers in Cc. >> >> Would the following additional API suffice the motivation? >> >> rte_flow_modify_action(struct r

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-04 Thread Andrey Vesnovaty
On Wed, Jun 3, 2020 at 1:53 PM Jerin Jacob wrote: > On Wed, May 20, 2020 at 2:48 PM Andrey Vesnovaty > wrote: > > > > This commit introduces extension of DPDK flow action API enabling > > modification of single rte_flow_action. > > > > Motivation and example > > === > > Adding or removing one or

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-04 Thread Andrey Vesnovaty
On Wed, Jun 3, 2020 at 1:02 PM Thomas Monjalon wrote: > 20/05/2020 11:18, Andrey Vesnovaty: > > This commit introduces extension of DPDK flow action API enabling > > modification of single rte_flow_action. > > > > Motivation and example > > === > > Adding or removing one or more queues to RSS act

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-03 Thread Jerin Jacob
On Wed, May 20, 2020 at 2:48 PM Andrey Vesnovaty wrote: > > This commit introduces extension of DPDK flow action API enabling > modification of single rte_flow_action. > > Motivation and example > === > Adding or removing one or more queues to RSS actions cloned in multiple > flow rules imposes pe

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-03 Thread Thomas Monjalon
20/05/2020 11:18, Andrey Vesnovaty: > This commit introduces extension of DPDK flow action API enabling > modification of single rte_flow_action. > > Motivation and example > === > Adding or removing one or more queues to RSS actions cloned in multiple > flow rules imposes per rule toll for curren

[dpdk-dev] [RFC] add flow action context API

2020-05-20 Thread Andrey Vesnovaty
This commit introduces extension of DPDK flow action API enabling modification of single rte_flow_action. Motivation and example === Adding or removing one or more queues to RSS actions cloned in multiple flow rules imposes per rule toll for current DPDK flow API; the scenario requires for each fl