Re: [dpdk-dev] [PATCHv4 1/5] buildtools: Add tool to check EXPERIMENTAL api exports

2018-01-21 Thread Neil Horman
On Sun, Jan 21, 2018 at 07:31:31PM +0100, Thomas Monjalon wrote: > Hi Neil, > > Sorry for the very late review. > I thought review had been done by others but it seems not. > Please find my comments below. > > 13/12/2017 16:17, Neil Horman: > > create mode 100755 buildtools/experimentalsyms.sh >

Re: [dpdk-dev] [PATCHv4 1/5] buildtools: Add tool to check EXPERIMENTAL api exports

2018-01-21 Thread Thomas Monjalon
Hi Neil, Sorry for the very late review. I thought review had been done by others but it seems not. Please find my comments below. 13/12/2017 16:17, Neil Horman: > create mode 100755 buildtools/experimentalsyms.sh When adding a new file, you must reference it in MAINTAINERS. Please add it in th

[dpdk-dev] [PATCHv4 1/5] buildtools: Add tool to check EXPERIMENTAL api exports

2017-12-13 Thread Neil Horman
This tools reads the given version map for a directory, and checks to ensure that, for each symbol listed in the export list, the corresponding definition is tagged as __experimental, erroring out if its not. In this way, we can ensure that the EXPERIMENTAL api is kept in sync with the tags Signe