Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics library

2017-02-02 Thread Thomas Monjalon
2017-01-31 13:28, Bruce Richardson: > On Tue, Jan 31, 2017 at 01:13:11PM +, Mcnamara, John wrote: > > From: Thomas Monjalon > > > Hi Remy, > > > > > > > This patch adds a new information metric library that allows other > > > > modules to register named metrics and update their values. It is >

Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics library

2017-01-31 Thread Bruce Richardson
gt; > Subject: Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics > > library > > > > Hi Remy, > > > > > This patch adds a new information metric library that allows other > > > modules to register named metrics and update their values. It is

Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics library

2017-01-31 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, January 30, 2017 3:50 PM > To: Horton, Remy > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics > library > > Hi R

Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics library

2017-01-30 Thread Remy Horton
Some points addressed. Will cover other ones later. On 30/01/2017 15:50, Thomas Monjalon wrote: [..] +CONFIG_RTE_LIBRTE_METRICS=y I know the config file is not so well sorted. However it would be a bit more logical below CONFIG_RTE_LIBRTE_JOBSTATS. Done. Rebase merging doesn't help with sor

Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics library

2017-01-30 Thread Thomas Monjalon
Hi Remy, > This patch adds a new information metric library that allows other > modules to register named metrics and update their values. It is > intended to be independent of ethdev, rather than mixing ethdev > and non-ethdev information in xstats. I'm still not convinced by this library, and t

[dpdk-dev] [PATCH v9 1/7] lib: add information metrics library

2017-01-18 Thread Remy Horton
This patch adds a new information metric library that allows other modules to register named metrics and update their values. It is intended to be independent of ethdev, rather than mixing ethdev and non-ethdev information in xstats. Signed-off-by: Remy Horton --- MAINTAINERS