Re: [dpdk-dev] [PATCH v9 06/10] ipsec: add transmit segmentation offload support

2021-10-27 Thread Nicolau, Radu
On 10/26/2021 6:45 PM, Ananyev, Konstantin wrote: Hi, I reworked this patch as part of a new patchset, and some comments below. On the comment about the offload capabilities, i.e. what happens if a PMD supports SECURITY and TSO but not both in the same time, well, if this is the case they sh

Re: [dpdk-dev] [PATCH v9 06/10] ipsec: add transmit segmentation offload support

2021-10-26 Thread Ananyev, Konstantin
> > Hi, I reworked this patch as part of a new patchset, and some comments > below. > > On the comment about the offload capabilities, i.e. what happens if a > PMD supports SECURITY and TSO but not both in the same time, well, if > this is the case they should not be set both, Ok, let' take a

Re: [dpdk-dev] [PATCH v9 06/10] ipsec: add transmit segmentation offload support

2021-10-18 Thread Nicolau, Radu
Hi, I reworked this patch as part of a new patchset, and some comments below. On the comment about the offload capabilities, i.e. what happens if a PMD supports SECURITY and TSO but not both in the same time, well, if this is the case they should not be set both, and also this can theoretical

Re: [dpdk-dev] [PATCH v9 06/10] ipsec: add transmit segmentation offload support

2021-10-14 Thread Ananyev, Konstantin
> > Add support for transmit segmentation offload to inline crypto processing > mode. This offload is not supported by other offload modes, as at a > minimum it requires inline crypto for IPsec to be supported on the > network interface. Thanks for rework. It looks much better to me now, but st

[dpdk-dev] [PATCH v9 06/10] ipsec: add transmit segmentation offload support

2021-10-13 Thread Radu Nicolau
Add support for transmit segmentation offload to inline crypto processing mode. This offload is not supported by other offload modes, as at a minimum it requires inline crypto for IPsec to be supported on the network interface. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off