Re: [dpdk-dev] [PATCH v9 03/12] eal: introduce memory management wrappers

2020-06-15 Thread Dmitry Kozlyuk
On Mon, 15 Jun 2020 06:53:45 -0400 Neil Horman wrote: > On Mon, Jun 15, 2020 at 10:41:20AM +0300, Dmitry Kozlyuk wrote: > > On Mon, 15 Jun 2020 07:03:23 +0100 > > "Kinsella, Ray" wrote: > > > > [snip] > > > > + > > > > +INTERNAL { > > > > + global: > > > > + > > > > + rte_mem_lock

Re: [dpdk-dev] [PATCH v9 03/12] eal: introduce memory management wrappers

2020-06-15 Thread Neil Horman
On Mon, Jun 15, 2020 at 10:41:20AM +0300, Dmitry Kozlyuk wrote: > On Mon, 15 Jun 2020 07:03:23 +0100 > "Kinsella, Ray" wrote: > > [snip] > > > + > > > +INTERNAL { > > > + global: > > > + > > > + rte_mem_lock; > > > + rte_mem_map; > > > + rte_mem_page_size; > > > + rte_mem_unmap; > > > +}; > >

Re: [dpdk-dev] [PATCH v9 03/12] eal: introduce memory management wrappers

2020-06-15 Thread Kinsella, Ray
perfect. On 15/06/2020 08:41, Dmitry Kozlyuk wrote: > On Mon, 15 Jun 2020 07:03:23 +0100 > "Kinsella, Ray" wrote: > > [snip] >>> + >>> +INTERNAL { >>> + global: >>> + >>> + rte_mem_lock; >>> + rte_mem_map; >>> + rte_mem_page_size; >>> + rte_mem_unmap; >>> +}; >> Don't >> >> * eal_mem_

Re: [dpdk-dev] [PATCH v9 03/12] eal: introduce memory management wrappers

2020-06-15 Thread Dmitry Kozlyuk
On Mon, 15 Jun 2020 07:03:23 +0100 "Kinsella, Ray" wrote: [snip] > > + > > +INTERNAL { > > + global: > > + > > + rte_mem_lock; > > + rte_mem_map; > > + rte_mem_page_size; > > + rte_mem_unmap; > > +}; > > Don't > > * eal_mem_reserve() > * eal_mem_free() > * eal_mem_set_dump() > > Be

Re: [dpdk-dev] [PATCH v9 03/12] eal: introduce memory management wrappers

2020-06-14 Thread Kinsella, Ray
On 15/06/2020 01:43, Dmitry Kozlyuk wrote: > Introduce OS-independent wrappers for memory management operations used > across DPDK and specifically in common code of EAL: > > * rte_mem_map() > * rte_mem_unmap() > * rte_mem_page_size() > * rte_mem_lock() > > Windows uses different APIs for memory

[dpdk-dev] [PATCH v9 03/12] eal: introduce memory management wrappers

2020-06-14 Thread Dmitry Kozlyuk
Introduce OS-independent wrappers for memory management operations used across DPDK and specifically in common code of EAL: * rte_mem_map() * rte_mem_unmap() * rte_mem_page_size() * rte_mem_lock() Windows uses different APIs for memory mapping and reservation, while Unices reserve memory by mappi