Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-14 Thread Thomas Monjalon
15/04/2021 00:08, Dmitry Kozlyuk: > 2021-04-14 14:47 (UTC-0700), Ranjit Menon: > > On 4/14/2021 2:42 PM, Thomas Monjalon wrote: > > > 14/04/2021 23:34, Ranjit Menon: > > >> On 4/14/2021 2:12 PM, Thomas Monjalon wrote: > > >>> 13/04/2021 09:00, Dmitry Kozlyuk: > > Hi Ranjit, > > > >

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-14 Thread Dmitry Kozlyuk
2021-04-14 14:47 (UTC-0700), Ranjit Menon: > On 4/14/2021 2:42 PM, Thomas Monjalon wrote: > > 14/04/2021 23:34, Ranjit Menon: > >> On 4/14/2021 2:12 PM, Thomas Monjalon wrote: > >>> 13/04/2021 09:00, Dmitry Kozlyuk: > Hi Ranjit, > > 2021-04-12 21:46 (UTC-0700), Ranjit Menon: >

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-14 Thread Ranjit Menon
On 4/14/2021 2:42 PM, Thomas Monjalon wrote: 14/04/2021 23:34, Ranjit Menon: On 4/14/2021 2:12 PM, Thomas Monjalon wrote: 13/04/2021 09:00, Dmitry Kozlyuk: Hi Ranjit, 2021-04-12 21:46 (UTC-0700), Ranjit Menon: [...] The change to remove the networking shim breaks l2fwd compilation on Windo

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-14 Thread Thomas Monjalon
14/04/2021 23:34, Ranjit Menon: > On 4/14/2021 2:12 PM, Thomas Monjalon wrote: > > 13/04/2021 09:00, Dmitry Kozlyuk: > >> Hi Ranjit, > >> > >> 2021-04-12 21:46 (UTC-0700), Ranjit Menon: > >> [...] > >>> The change to remove the networking shim breaks l2fwd compilation on > >>> Windows, since l2fwd/

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-14 Thread Ranjit Menon
On 4/14/2021 2:12 PM, Thomas Monjalon wrote: 13/04/2021 09:00, Dmitry Kozlyuk: Hi Ranjit, 2021-04-12 21:46 (UTC-0700), Ranjit Menon: [...] The change to remove the networking shim breaks l2fwd compilation on Windows, since l2fwd/main.c includes netinet/in.h explicitly. How do you propose we

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-14 Thread Thomas Monjalon
13/04/2021 09:00, Dmitry Kozlyuk: > Hi Ranjit, > > 2021-04-12 21:46 (UTC-0700), Ranjit Menon: > [...] > > The change to remove the networking shim breaks l2fwd compilation on > > Windows, since l2fwd/main.c includes netinet/in.h explicitly. > > > > How do you propose we fix this, only for Window

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-13 Thread Dmitry Kozlyuk
Hi Ranjit, 2021-04-12 21:46 (UTC-0700), Ranjit Menon: [...] > The change to remove the networking shim breaks l2fwd compilation on > Windows, since l2fwd/main.c includes netinet/in.h explicitly. > > How do you propose we fix this, only for Windows? This include is redundant for this file on all

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-12 Thread Ranjit Menon
Hi Dmitry, On 4/10/2021 3:47 PM, Dmitry Kozlyuk wrote: On Windows, EAL contains two sets of functions and macros for POSIX compatibility: and a networking shim (socket headers). The latter conflicts with system headers and should not exist. Exposing the former from EAL can break consumer own PO

[dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-10 Thread Dmitry Kozlyuk
On Windows, EAL contains two sets of functions and macros for POSIX compatibility: and a networking shim (socket headers). The latter conflicts with system headers and should not exist. Exposing the former from EAL can break consumer own POSIX compatibility layer and is against standards in genera