Re: [dpdk-dev] [PATCH v8 6/6] devargs: parse bus info

2017-07-08 Thread Thomas Monjalon
07/07/2017 10:31, Gaëtan Rivet: > On Thu, Jul 06, 2017 at 05:45:02PM -0700, Stephen Hemminger wrote: > > On Fri, 7 Jul 2017 02:03:12 +0200 > > Gaetan Rivet wrote: > > > > > +static int > > > +bus_name_cmp(const struct rte_bus *bus, const void *_name) > > > +{ > > > + const char *name = _name; >

Re: [dpdk-dev] [PATCH v8 6/6] devargs: parse bus info

2017-07-07 Thread Gaëtan Rivet
On Thu, Jul 06, 2017 at 05:45:02PM -0700, Stephen Hemminger wrote: > On Fri, 7 Jul 2017 02:03:12 +0200 > Gaetan Rivet wrote: > > > +static int > > +bus_name_cmp(const struct rte_bus *bus, const void *_name) > > +{ > > + const char *name = _name; > > + > > + return strncmp(bus->name, name, >

Re: [dpdk-dev] [PATCH v8 6/6] devargs: parse bus info

2017-07-06 Thread Stephen Hemminger
On Fri, 7 Jul 2017 02:03:12 +0200 Gaetan Rivet wrote: > +static int > +bus_name_cmp(const struct rte_bus *bus, const void *_name) > +{ > + const char *name = _name; > + > + return strncmp(bus->name, name, > +strlen(bus->name)); I don't think you need the _name variab

[dpdk-dev] [PATCH v8 6/6] devargs: parse bus info

2017-07-06 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_devargs.c | 42 - lib/librte_eal/common/eal_common_vdev.c | 6 +++-- lib/librte_eal/common/include/rte_devargs.h | 3 +++ 3 files changed, 42 insertions(+), 9 deletions(-)