Re: [dpdk-dev] [PATCH v8 07/10] eal: replace rte_panic instances in hugepage_info

2018-04-25 Thread Burakov, Anatoly
On 25-Apr-18 3:02 PM, Arnon Warshavsky wrote: I think i've already acked this. You should keep acks etc. between versions (unless you're making significant enough changes that you think would invalidate a prior ack). Having acks makes it easier to track what still needs to be rev

Re: [dpdk-dev] [PATCH v8 07/10] eal: replace rte_panic instances in hugepage_info

2018-04-25 Thread Arnon Warshavsky
> I think i've already acked this. You should keep acks etc. between > versions (unless you're making significant enough changes that you think > would invalidate a prior ack). Having acks makes it easier to track what > still needs to be reviewed and what is good to go, and it makes it easier > to

Re: [dpdk-dev] [PATCH v8 07/10] eal: replace rte_panic instances in hugepage_info

2018-04-25 Thread Burakov, Anatoly
On 25-Apr-18 2:45 PM, Arnon Warshavsky wrote: replace panic calls with log and return value. Signed-off-by: Arnon Warshavsky --- I think i've already acked this. You should keep acks etc. between versions (unless you're making significant enough changes that you think would invalidate a pri

[dpdk-dev] [PATCH v8 07/10] eal: replace rte_panic instances in hugepage_info

2018-04-25 Thread Arnon Warshavsky
replace panic calls with log and return value. Signed-off-by: Arnon Warshavsky --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 + 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/lin