Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD

2017-07-11 Thread Gaëtan Rivet
On Wed, Jul 12, 2017 at 12:21:24AM +0200, Thomas Monjalon wrote: > 11/07/2017 23:48, Gaëtan Rivet: > > On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote: > > > 11/07/2017 01:19, Gaetan Rivet: > > > > --- /dev/null > > > > +++ b/drivers/net/failsafe/failsafe_args.c > > > [...] > > > >

Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD

2017-07-11 Thread Thomas Monjalon
11/07/2017 23:48, Gaëtan Rivet: > On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote: > > 11/07/2017 01:19, Gaetan Rivet: > > > --- /dev/null > > > +++ b/drivers/net/failsafe/failsafe_args.c > > [...] > > > +#include > > > > Do you really need errno in this file? > > It's used for e

Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD

2017-07-11 Thread Gaëtan Rivet
On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote: > 11/07/2017 01:19, Gaetan Rivet: > > --- /dev/null > > +++ b/drivers/net/failsafe/failsafe_args.c > [...] > > +#include > > Do you really need errno in this file? It's used for error handling on strtoull and popen. Why, is it a pr

Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD

2017-07-11 Thread Thomas Monjalon
11/07/2017 01:19, Gaetan Rivet: > --- /dev/null > +++ b/drivers/net/failsafe/failsafe_args.c [...] > +#include Do you really need errno in this file?

[dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD

2017-07-10 Thread Gaetan Rivet
Introduce the fail-safe poll mode driver initialization and enable its build infrastructure. This PMD allows for applications to benefit from true hot-plugging support without having to implement it. It intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes