2014-11-25 10:56, Jastrzebski, MichalX K:
> I noticed some problems with applying link bonding mode 4 patches after you
> applied Declan's patches.
> Link bonding mode 4 0001-bond-add-mode-4-support.patch won't apply because of
> this error:
> Checking patch lib/librte_pmd_bond/rte_eth_bond_priv
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, November 24, 2014 9:54 PM
> To: Doherty, Declan
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v8 0/7] link bonding
>
> 2014-11-24 16:33
2014-11-24 16:33, Declan Doherty:
> v8:
> - Missing typo fix
> - Missing whitespace
>
> v7:
> - Fixes for checkpatch issues and typo fixes
> - Removed patch "test app: adding support for generating variable sized" as
> this
> was already committed in commit aca4360340f169dcc11b1a9be955b44de8b9f
2014-11-24 19:32, Thomas Monjalon:
> I'm fixing it for you because I'm losing confidence all bonding patches will
> be ready on time.
I've just understood what happened.
I think it's a wrong git manipulation: the fixes were squashed in the last
commit, so the patch 6/7 was still having issues.
--
Declan,
There are still some missing spaces:
WARNING:MISSING_SPACE: break quoted strings at a space character
#2002: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1406:
+ "Invalid lsc polling interval value
specified for bonded"
+
v8:
- Missing typo fix
- Missing whitespace
v7:
- Fixes for checkpatch issues and typo fixes
- Removed patch "test app: adding support for generating variable sized" as this
was already committed in commit aca4360340f169dcc11b1a9be955b44de8b9f6eb
v6:
- Re-based to dpdk.org addressing associated
6 matches
Mail list logo
