On 2019/5/8 18:22, Thomas Monjalon wrote:
About the title, you can write: "app/pdump: exit with primary process"
08/05/2019 11:37, Suanming. Mou:
On 2019/5/8 16:04, Thomas Monjalon wrote:
Hi,
I try to suggest some rewording below.
Thanks very much.
First, let me explain what is the patch
About the title, you can write: "app/pdump: exit with primary process"
08/05/2019 11:37, Suanming. Mou:
> On 2019/5/8 16:04, Thomas Monjalon wrote:
> > Hi,
> >
> > I try to suggest some rewording below.
>
> Thanks very much.
>
> First, let me explain what is the patch work for.
>
> As we all k
On 2019/5/8 16:04, Thomas Monjalon wrote:
Hi,
I try to suggest some rewording below.
Thanks very much.
First, let me explain what is the patch work for.
As we all know, the pdump tool works as the secondary process.
When the primary process exits, if the secondary process keeps running
Hi,
I try to suggest some rewording below.
03/05/2019 07:48, Suanming. Mou:
> +/* Enough to set it to 500ms for exiting. */
> +#define MONITOR_INTERVAL (500 * 1000)
What is "enough"?
What is "it"?
What is the relation between MONITOR_INTERVAL and exiting?
[...]
> + /*
> + * Don't worry
On 2019/5/5 17:42, Thomas Monjalon wrote:
Yes, either to wait one week, or fake the 19.08 release notes template
to do your patch on top.
Thanks. I think it will be updated when 19.08 started.
05/05/2019 03:20, Suanming. Mou:
> On 2019/5/5 5:17, Thomas Monjalon wrote:
> > Hi,
> >
> > 03/05/2019 07:48, Suanming. Mou:
> >> When primary app exits, the residual running pdump will stop the
> >> primary app to restart. Add pdump exits with primary support.
> > Sorry I fail to parse this senten
On 2019/5/5 5:17, Thomas Monjalon wrote:
Hi,
03/05/2019 07:48, Suanming. Mou:
When primary app exits, the residual running pdump will stop the
primary app to restart. Add pdump exits with primary support.
Sorry I fail to parse this sentence.
Maybe it should be longer to be more explicit abou
Hi,
03/05/2019 07:48, Suanming. Mou:
> When primary app exits, the residual running pdump will stop the
> primary app to restart. Add pdump exits with primary support.
Sorry I fail to parse this sentence.
Maybe it should be longer to be more explicit about
what it the current issue and how it is
When primary app exits, the residual running pdump will stop the
primary app to restart. Add pdump exits with primary support.
Signed-off-by: Suanming.Mou
Reviewed-by: Anatoly Burakov
Reviewed-by: Vipin Varghese
---
V8:
* reword the print info in monitor_primary.
* add release_19_05.rst update.
9 matches
Mail list logo
