Re: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-10-13 Thread Kavanagh, Mark B
>From: Yigit, Ferruh >Sent: Friday, October 13, 2017 3:50 AM >To: Patrick MacArthur ; Markus Theil >; dev@dpdk.org; Kavanagh, Mark B > >Cc: step...@networkplumber.org; Bob Noseworthy ; Patrick >MacArthur ; O'Driscoll, Tim >Subject: Re: [dpdk-dev] [PATCH v7 5/6] igb_

Re: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-10-12 Thread Ferruh Yigit
On 10/12/2017 6:04 PM, Ferruh Yigit wrote: > On 10/9/2017 10:56 PM, Patrick MacArthur wrote: >> Hi, Markus, >> >> This commit appears to cause a regression on CentOS 7.4 with the in-box >> Linux 3.10.0-639-2.2.el7.x86_64 kernel. Although the kernel module >> appears to build correctly, when I att

Re: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-10-12 Thread Ferruh Yigit
On 10/12/2017 10:15 PM, Stephen Hemminger wrote: > Are the symbols exported? No! They started to be exported in v4.5. I will update accordingly. Thanks, ferruh > > On Oct 12, 2017 13:58, "Ferruh Yigit" > wrote: > > On 10/12/2017 11:50 AM, Kavanagh, Mark B w

Re: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-10-12 Thread Stephen Hemminger
Are the symbols exported? On Oct 12, 2017 13:58, "Ferruh Yigit" wrote: > On 10/12/2017 11:50 AM, Kavanagh, Mark B wrote: > > Hi, > > > > This commit renders igb_uio unusable on Fedora 20, kernel version > 3.19.8-100.fc20.x86_64. > > > > During the build (make -j 20), a warning is issued for igb_

Re: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-10-12 Thread Ferruh Yigit
On 10/12/2017 11:50 AM, Kavanagh, Mark B wrote: > Hi, > > This commit renders igb_uio unusable on Fedora 20, kernel version > 3.19.8-100.fc20.x86_64. > > During the build (make -j 20), a warning is issued for igb_uio regarding a > missing symbol (pci_msi_unmask): > WARNING: "pci_msi_unmas

Re: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-10-12 Thread Ferruh Yigit
On 10/9/2017 10:56 PM, Patrick MacArthur wrote: > Hi, Markus, > > This commit appears to cause a regression on CentOS 7.4 with the in-box > Linux 3.10.0-639-2.2.el7.x86_64 kernel. Although the kernel module > appears to build correctly, when I attempt to load the module with > insmod, it fails

Re: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-10-12 Thread Kavanagh, Mark B
dev@dpdk.org >Cc: Yigit, Ferruh ; step...@networkplumber.org; Markus >Theil >Subject: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking >MSI-X > >This patch removes the custom MSI-X mask/unmask code and >uses already existing kernel functions. > >Signed-o

Re: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-10-09 Thread Patrick MacArthur
Hi, Markus, This commit appears to cause a regression on CentOS 7.4 with the in-box Linux 3.10.0-639-2.2.el7.x86_64 kernel. Although the kernel module appears to build correctly, when I attempt to load the module with insmod, it fails and I see the following errors in dmesg: [620323.805125]

[dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-09-05 Thread Markus Theil
This patch removes the custom MSI-X mask/unmask code and uses already existing kernel functions. Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 26 +--- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 51 --- 2 files changed, 28 in