Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-21 Thread Thomas Monjalon
21/07/2020 14:51, Parav Pandit: > > > From: Thomas Monjalon > > Sent: Tuesday, July 21, 2020 5:57 PM > > > > 21/07/2020 14:13, Parav Pandit: > > > From: David Marchand > > > > On Tue, Jul 21, 2020 at 1:19 PM Parav Pandit > > wrote: > > > > > > This way, net/mlx5 and vdpa/mlx5 will pass their i

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-21 Thread Parav Pandit
> From: Thomas Monjalon > Sent: Tuesday, July 21, 2020 5:57 PM > > 21/07/2020 14:13, Parav Pandit: > > From: David Marchand > > > On Tue, Jul 21, 2020 at 1:19 PM Parav Pandit > wrote: > > > > > This way, net/mlx5 and vdpa/mlx5 will pass their id_map to the > > > > > mlx5 pci driver whether i

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-21 Thread Thomas Monjalon
21/07/2020 14:13, Parav Pandit: > From: David Marchand > > On Tue, Jul 21, 2020 at 1:19 PM Parav Pandit wrote: > > > > This way, net/mlx5 and vdpa/mlx5 will pass their id_map to the mlx5 > > > > pci driver whether it is registered to the pci bus or not yet. > > > > > > And here pci_id_table will

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-21 Thread Parav Pandit
> From: David Marchand > Sent: Tuesday, July 21, 2020 4:59 PM > > On Tue, Jul 21, 2020 at 1:19 PM Parav Pandit wrote: > > > This way, net/mlx5 and vdpa/mlx5 will pass their id_map to the mlx5 > > > pci driver whether it is registered to the pci bus or not yet. > > > > And here pci_id_table wil

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-21 Thread Thomas Monjalon
21/07/2020 13:29, David Marchand: > On Tue, Jul 21, 2020 at 1:19 PM Parav Pandit wrote: > > Basically mlx5_pci_bus, mlx5_net and mlx5_vdpa will be called with same > > priority RTE_PRIO_LAST. > > driver id table and drv_flags dynamically updated as PMDs register. > > > > Should we have another API

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-21 Thread David Marchand
On Tue, Jul 21, 2020 at 1:19 PM Parav Pandit wrote: > > This way, net/mlx5 and vdpa/mlx5 will pass their id_map to the mlx5 > > pci driver whether it is registered to the pci bus or not yet. > > And here pci_id_table will not be const *. > Is that ok? This is already the case in the current patch

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-21 Thread Parav Pandit
Hi David, On 7/21/2020 3:04 PM, David Marchand wrote: > On Mon, Jul 20, 2020 at 9:30 PM Ori Kam wrote: >>> net and vdpa code expect the common code being initialised. >>> It is a dependency internal to mlx5 drivers, I see nothing generic. >>> >> First the idea was to declare a new bus not a PMD.

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-21 Thread David Marchand
On Mon, Jul 20, 2020 at 9:30 PM Ori Kam wrote: > > net and vdpa code expect the common code being initialised. > > It is a dependency internal to mlx5 drivers, I see nothing generic. > > > First the idea was to declare a new bus not a PMD. > The issue is not from common code but from loading more

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ori Kam
Hi David, > -Original Message- > From: David Marchand > > On Mon, Jul 20, 2020 at 6:48 PM Thomas Monjalon > wrote: > > > > 20/07/2020 18:21, Ferruh Yigit: > > > On 7/17/2020 2:49 PM, Parav Pandit wrote: > > > > Currently mlx5_common uses CLASS priority to initialize > > > > common code

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > > On 7/20/2020 6:26 PM, Ori Kam wrote: > > Hi > > > >> -Original Message- > >> From: Ferruh Yigit > >> On 7/20/2020 5:48 PM, Thomas Monjalon wrote: > >>> 20/07/2020 18:21, Ferruh Yigit: > On 7/17/2020 2:49 PM, Parav Pandit wrote:

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread David Marchand
On Mon, Jul 20, 2020 at 6:48 PM Thomas Monjalon wrote: > > 20/07/2020 18:21, Ferruh Yigit: > > On 7/17/2020 2:49 PM, Parav Pandit wrote: > > > Currently mlx5_common uses CLASS priority to initialize > > > common code before initializing the PMD. > > > However mlx5_common is not really a class, it

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 6:26 PM, Ori Kam wrote: > Hi > >> -Original Message- >> From: Ferruh Yigit >> On 7/20/2020 5:48 PM, Thomas Monjalon wrote: >>> 20/07/2020 18:21, Ferruh Yigit: On 7/17/2020 2:49 PM, Parav Pandit wrote: > Currently mlx5_common uses CLASS priority to initialize > co

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ori Kam
Hi > -Original Message- > From: Ferruh Yigit > On 7/20/2020 5:48 PM, Thomas Monjalon wrote: > > 20/07/2020 18:21, Ferruh Yigit: > >> On 7/17/2020 2:49 PM, Parav Pandit wrote: > >>> Currently mlx5_common uses CLASS priority to initialize > >>> common code before initializing the PMD. > >>>

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 5:48 PM, Thomas Monjalon wrote: > 20/07/2020 18:21, Ferruh Yigit: >> On 7/17/2020 2:49 PM, Parav Pandit wrote: >>> Currently mlx5_common uses CLASS priority to initialize >>> common code before initializing the PMD. >>> However mlx5_common is not really a class, it is the pre-initializ

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Thomas Monjalon
20/07/2020 18:21, Ferruh Yigit: > On 7/17/2020 2:49 PM, Parav Pandit wrote: > > Currently mlx5_common uses CLASS priority to initialize > > common code before initializing the PMD. > > However mlx5_common is not really a class, it is the pre-initialization > > code needed for the PMDs. > > > > In

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ferruh Yigit
On 7/17/2020 2:49 PM, Parav Pandit wrote: > Currently mlx5_common uses CLASS priority to initialize > common code before initializing the PMD. > However mlx5_common is not really a class, it is the pre-initialization > code needed for the PMDs. > > In subsequent patch a needed initialization seque

[dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-17 Thread Parav Pandit
Currently mlx5_common uses CLASS priority to initialize common code before initializing the PMD. However mlx5_common is not really a class, it is the pre-initialization code needed for the PMDs. In subsequent patch a needed initialization sequence is: (a) Initialize bus (say pci) (b) Initialize co